Issue 219243006: Revert "Removed unused includes from UnicodeIcu.h"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 219243006: Revert "Removed unused includes from UnicodeIcu.h" (Closed)

Created:
6 years, 8 months ago by rafaelw

Modified:
6 years, 8 months ago

Reviewers:
zvorygin

CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, abarth-chromium, danakj, Rik, adamk+blink_chromium.org, Inactive, Stephen Chennney, Mikhail, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "Removed unused includes from UnicodeIcu.h" Caused build failures on Android. TBR=zvorygin BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170467

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -10 lines)			Patch
M	Source/platform/fonts/FontDescription.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/platform/fonts/GenericFontFamilySettings.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/platform/fonts/harfbuzz/HarfBuzzShaper.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/platform/text/LocaleToScriptMapping.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/platform/text/TextBreakIterator.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/platform/text/TextBreakIteratorICU.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/wtf/unicode/icu/UnicodeIcu.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rafaelw

e.g. http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/37362/steps/compile/logs/stdio

6 years, 8 months ago (2014-03-31 18:19:07 UTC) #1

rafaelw

6 years, 8 months ago (2014-03-31 18:19:28 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r170467 (presubmit successful).

Expand Messages | Collapse Messages