Show at most one PaymentRequest UI at a time.

Show at most one PaymentRequest UI at a time.

If the webpage calls PaymentRequest.show() while another
PaymentRequest UI is already showing, then reject the second
show() promise.

In addition, this patch performs "OK to create
PaymentRequest" checks inside of the PaymentRequestFactory
instead of the PaymentRequestImpl constructor. That way
PaymentRequestImpl is guaranteed to have a valid state.
This allows many variables in PaymentRequestImpl to become
final.

BUG=633610
Committed: https://crrev.com/8401134848abbb32f99de0f188f730f706e9ae42
Cr-Commit-Position: refs/heads/master@{#409371}

[please use gerrit instead, 2016-08-01 23:26:07]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 23:26:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-08-02 00:05:22]

Description was changed from

==========
WIP

BUG=
==========

to

==========
Show at most one PaymentRequest UI at a time.

If the webpage calls PaymentRequest.show() while another
PaymentRequest UI is already showing, then reject the second
show() promise.

In addition, this patch performs "OK to create
PaymentRequest" checks inside of the PaymentRequestFactory
instead of the PaymentRequestImpl constructor. That way
PaymentRequestImpl is guaranteed to have a valid state.
This allows many variables in PaymentRequestImpl to become
final.

BUG=
==========

[commit-bot: I haz the power, 2016-08-02 00:29:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 00:29:36]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[please use gerrit instead, 2016-08-02 16:27:04]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-08-02 16:28:09]

Description was changed from

==========
Show at most one PaymentRequest UI at a time.

If the webpage calls PaymentRequest.show() while another
PaymentRequest UI is already showing, then reject the second
show() promise.

In addition, this patch performs "OK to create
PaymentRequest" checks inside of the PaymentRequestFactory
instead of the PaymentRequestImpl constructor. That way
PaymentRequestImpl is guaranteed to have a valid state.
This allows many variables in PaymentRequestImpl to become
final.

BUG=
==========

to

==========
Show at most one PaymentRequest UI at a time.

If the webpage calls PaymentRequest.show() while another
PaymentRequest UI is already showing, then reject the second
show() promise.

In addition, this patch performs "OK to create
PaymentRequest" checks inside of the PaymentRequestFactory
instead of the PaymentRequestImpl constructor. That way
PaymentRequestImpl is guaranteed to have a valid state.
This allows many variables in PaymentRequestImpl to become
final.

BUG=633610
==========

[please use gerrit instead, 2016-08-02 16:29:44]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2016-08-02 16:29:44]

dfalcantara, ptal.

[gone, 2016-08-02 21:04:49]

lgtm

[please use gerrit instead, 2016-08-02 22:32:13]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2016-08-02 22:33:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 23:10:59]

Description was changed from

==========
Show at most one PaymentRequest UI at a time.

If the webpage calls PaymentRequest.show() while another
PaymentRequest UI is already showing, then reject the second
show() promise.

In addition, this patch performs "OK to create
PaymentRequest" checks inside of the PaymentRequestFactory
instead of the PaymentRequestImpl constructor. That way
PaymentRequestImpl is guaranteed to have a valid state.
This allows many variables in PaymentRequestImpl to become
final.

BUG=633610
==========

to

==========
Show at most one PaymentRequest UI at a time.

If the webpage calls PaymentRequest.show() while another
PaymentRequest UI is already showing, then reject the second
show() promise.

In addition, this patch performs "OK to create
PaymentRequest" checks inside of the PaymentRequestFactory
instead of the PaymentRequestImpl constructor. That way
PaymentRequestImpl is guaranteed to have a valid state.
This allows many variables in PaymentRequestImpl to become
final.

BUG=633610
==========

[commit-bot: I haz the power, 2016-08-02 23:11:00]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-08-02 23:12:32]

Description was changed from

==========
Show at most one PaymentRequest UI at a time.

If the webpage calls PaymentRequest.show() while another
PaymentRequest UI is already showing, then reject the second
show() promise.

In addition, this patch performs "OK to create
PaymentRequest" checks inside of the PaymentRequestFactory
instead of the PaymentRequestImpl constructor. That way
PaymentRequestImpl is guaranteed to have a valid state.
This allows many variables in PaymentRequestImpl to become
final.

BUG=633610
==========

to

==========
Show at most one PaymentRequest UI at a time.

If the webpage calls PaymentRequest.show() while another
PaymentRequest UI is already showing, then reject the second
show() promise.

In addition, this patch performs "OK to create
PaymentRequest" checks inside of the PaymentRequestFactory
instead of the PaymentRequestImpl constructor. That way
PaymentRequestImpl is guaranteed to have a valid state.
This allows many variables in PaymentRequestImpl to become
final.

BUG=633610

Committed: https://crrev.com/8401134848abbb32f99de0f188f730f706e9ae42
Cr-Commit-Position: refs/heads/master@{#409371}
==========

[commit-bot: I haz the power, 2016-08-02 23:12:33]

Patchset 1 (id:??) landed as
https://crrev.com/8401134848abbb32f99de0f188f730f706e9ae42
Cr-Commit-Position: refs/heads/master@{#409371}