third_party/WebKit/Source/modules/payments/PaymentResponse.cpp - Issue 2192413002: Timeout if website never completes the transaction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

Issue 2192413002: Timeout if website never completes the transaction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Marijn's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

index 37b267bb42ffbe7dd1af149058dfe4020a531570..bf3d7662f2e52a463842400554baf2365e5a8418 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

@@ -34,11 +34,11 @@ ScriptValue PaymentResponse::details(ScriptState* scriptState, ExceptionState& e

ScriptPromise PaymentResponse::complete(ScriptState* scriptState, const String& result)

{

- PaymentComplete convertedResult = Unknown;

+ PaymentCompleter::PaymentComplete convertedResult = PaymentCompleter::Unknown;

if (result == "success")

- convertedResult = Success;

- if (result == "fail")

- convertedResult = Fail;

+ convertedResult = PaymentCompleter::Success;

+ else if (result == "fail")

+ convertedResult = PaymentCompleter::Fail;

return m_paymentCompleter->complete(scriptState, convertedResult);

}