Make new Harmony constructors subclassing-friendly

test/mjsunit/harmony/typedarrays.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
 //       with the distribution.
 //     * Neither the name of Google Inc. nor the names of its
 //       contributors may be used to endorse or promote products derived
 //       from this software without specific prior written permission.
 //
 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+//
+// Flags: --allow-natives-syntax
 
 // ArrayBuffer
 
 function TestByteLength(param, expectedByteLength) {
   var ab = new ArrayBuffer(param);
   assertSame(expectedByteLength, ab.byteLength);
 }
 
 function TestArrayBufferCreation() {
   TestByteLength(1, 1);
@@ skipping 515 matching lines @@
   assertArrayEquals([], props(func.prototype));
   if (obj)
     assertArrayEquals([], props(obj));
 }
 TestEnumerable(ArrayBuffer, new ArrayBuffer());
 for(i = 0; i < typedArrayConstructors.lenght; i++) {
   TestEnumerable(typedArrayConstructors[i]);
 }
 TestEnumerable(DataView, new DataView(new ArrayBuffer()));
 
-// Test arbitrary properties on ArrayBuffer
+// Test arbitrary properties on ArrayBuffer and DataView
 function TestArbitrary(m) {
   function TestProperty(map, property, value) {
     map[property] = value;
     assertEquals(value, map[property]);
   }
   for (var i = 0; i < 20; i++) {
     TestProperty(m, i, 'val' + i);
     TestProperty(m, 'foo' + i, 'bar' + i);
   }
 }
 TestArbitrary(new ArrayBuffer(256));
-for(i = 0; i < typedArrayConstructors.lenght; i++) {
-  TestArbitary(new typedArrayConstructors[i](10));
+TestArbitrary(new DataView(new ArrayBuffer(256)));
+
+// Test arbitrary properties on TypedArrays
+function TestArbitraryNonIndexed(m) {
+  function TestProperty(map, property, value) {
+    map[property] = value;
+    assertEquals(value, map[property]);
+  }
+  for (var i = 0; i < 20; i++) {
+    TestProperty(m, 'foo' + i, 'bar' + i);
+  }
 }
-TestArbitrary(new DataView(new ArrayBuffer(256)));
+for(i = 0; i < typedArrayConstructors.length; i++) {
+  TestArbitraryNonIndexed(new typedArrayConstructors[i](10));
+}
 
 
 // Test direct constructor call
 assertThrows(function() { ArrayBuffer(); }, TypeError);
 assertThrows(function() { DataView(new ArrayBuffer()); }, TypeError);
+
+// Test that constructor can be called only on appropriate objects only once.
+function TestConstructorBehavior(C) {
+  var obj = new C();
+  assertThrows(function() { C.call(obj); }, TypeError);
+  assertThrows(function() { C.call({}); }, TypeError);
+  var uninitObj = %NewObject(C);
+  C.call(uninitObj); // shouldn't throw
+}
+
+TestConstructorBehavior(ArrayBuffer);
+for(i = 0; i < typedArrayConstructors.length; i++) {
+  TestConstructorBehavior(typedArrayConstructors[i]);
+}
+
+
+// Test that DataView constructor can be called only on appropriate objects
+// only once.
+function TestDataViewConstructorBehavior() {
+  var ab = new ArrayBuffer(100);
+  var obj = new DataView(ab);
+  assertThrows(function() { DataView.call(obj, ab); }, TypeError);
+  assertThrows(function() { DataView.call({}, ab); }, TypeError);
+  var uninitObj = %NewObject(DataView);
+  DataView.call(uninitObj, ab); // shouldn't throw
+}
+TestDataViewConstructorBehavior();