Make new Harmony constructors subclassing-friendly

src/typedarray.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 67 matching lines @@
     var length = arrayLike.length;
     var l =  ToPositiveInteger(length, "invalid_typed_array_length");
     if(!%TypedArrayInitializeFromArrayLike(obj, arrayId, arrayLike, l)) {
       for (var i = 0; i < l; i++) {
         obj[i] = arrayLike[i];
       }
     }
   }
 
   return function (arg1, arg2, arg3) {
-    if (%_IsConstructCall()) {
-      if (IS_ARRAYBUFFER(arg1)) {
-        ConstructByArrayBuffer(this, arg1, arg2, arg3);
-      } else if (IS_NUMBER(arg1) || IS_STRING(arg1) ||
-                 IS_BOOLEAN(arg1) || IS_UNDEFINED(arg1)) {
-        ConstructByLength(this, arg1);
-      } else {
-        ConstructByArrayLike(this, arg1);
-      }
+    if (IS_ARRAYBUFFER(arg1)) {
+      ConstructByArrayBuffer(this, arg1, arg2, arg3);
+    } else if (IS_NUMBER(arg1) || IS_STRING(arg1) ||
+               IS_BOOLEAN(arg1) || IS_UNDEFINED(arg1)) {
+      ConstructByLength(this, arg1);
     } else {
-      throw MakeTypeError("constructor_not_function", [name])
+      ConstructByArrayLike(this, arg1);
     }
   }
 }
 
 function TypedArrayGetBuffer() {
   return %TypedArrayGetBuffer(this);
 }
 
 function TypedArrayGetByteLength() {
   return %TypedArrayGetByteLength(this);
@@ skipping 171 matching lines @@
 SetupTypedArray(7, "Float32Array", global.Float32Array, 4);
 SetupTypedArray(8, "Float64Array", global.Float64Array, 8);
 SetupTypedArray(9, "Uint8ClampedArray", global.Uint8ClampedArray, 1);
 
 
 // --------------------------- DataView -----------------------------
 
 var $DataView = global.DataView;
 
 function DataViewConstructor(buffer, byteOffset, byteLength) { // length = 3
-  if (%_IsConstructCall()) {
-    if (!IS_ARRAYBUFFER(buffer)) {
-      throw MakeTypeError('data_view_not_array_buffer', []);
-    }
-    var bufferByteLength = %ArrayBufferGetByteLength(buffer);
-    var offset = ToPositiveInteger(byteOffset, 'invalid_data_view_offset');
-    if (offset > bufferByteLength) {
-      throw MakeRangeError('invalid_data_view_offset');
-    }
-    var length = IS_UNDEFINED(byteLength) ?
-      bufferByteLength - offset : TO_INTEGER(byteLength);
-    if (length < 0 || offset + length > bufferByteLength) {
-      throw new MakeRangeError('invalid_data_view_length');
-    }
-    %DataViewInitialize(this, buffer, offset, length);
-  } else {
-    throw MakeTypeError('constructor_not_function', ["DataView"]);
+  if (!IS_ARRAYBUFFER(buffer)) {
+    throw MakeTypeError('data_view_not_array_buffer', []);
   }
+  var bufferByteLength = %ArrayBufferGetByteLength(buffer);
+  var offset = ToPositiveInteger(byteOffset, 'invalid_data_view_offset');
+  if (offset > bufferByteLength) {
+    throw MakeRangeError('invalid_data_view_offset');
+  }
+  var length = IS_UNDEFINED(byteLength) ?
+    bufferByteLength - offset : TO_INTEGER(byteLength);
+  if (length < 0 || offset + length > bufferByteLength) {
+    throw new MakeRangeError('invalid_data_view_length');
+  }
+  %DataViewInitialize(this, buffer, offset, length);
 }
 
 function DataViewGetBuffer() {
   if (!IS_DATAVIEW(this)) {
     throw MakeTypeError('incompatible_method_receiver',
                         ['DataView.buffer', this]);
   }
   return %DataViewGetBuffer(this);
 }
 
@@ skipping 268 matching lines @@
 
       "getFloat32", DataViewGetFloat32,
       "setFloat32", DataViewSetFloat32,
 
       "getFloat64", DataViewGetFloat64,
       "setFloat64", DataViewSetFloat64
   ));
 }
 
 SetupDataView();