Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issue 2192393003: Reland of Try yet again to flip official win builders to GN. (Closed)

Created:
4 years, 4 months ago by tapted
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Try yet again to flip official win builders to GN. (patchset #1 id:1 of https://codereview.chromium.org/2196993002/ ) Reason for revert: Didn't help - NaCl still crashing. Original issue's description: > Revert of Try yet again to flip official win builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2192303002/ ) > > Reason for revert: > All the NaCl tests are crashing with "Actual: "Plugin crashed. 'NaCl module crashed" since > https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504 > > This seems to be the most likely cause :( > > There's also an outstanding issue with win-pgo (see BUG=) > > BUG=632864 > > Original issue's description: > > Try yet again to flip official win builders to GN. > > > > TBR=brettw@chromium.org > > NOTRY=true > > BUG=623659 > > > > Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3 > > Cr-Commit-Position: refs/heads/master@{#408782} > > TBR=brettw@chromium.org,dpranke@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=623659 > NOTRY=true > > Committed: https://crrev.com/30fbb2688486ee1534b3035c9c89a6003181c2f8 > Cr-Commit-Position: refs/heads/master@{#408896} TBR=brettw@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=632864 Committed: https://crrev.com/3f3efb0d272ede1c6df075935a32fb3eba06dc13 Cr-Commit-Position: refs/heads/master@{#408897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -17 lines) Patch
M tools/mb/mb_config.pyl View 7 chunks +21 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Created Reland of Try yet again to flip official win builders to GN.
4 years, 4 months ago (2016-08-01 01:26:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192393003/1
4 years, 4 months ago (2016-08-01 01:26:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 01:28:21 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3f3efb0d272ede1c6df075935a32fb3eba06dc13 Cr-Commit-Position: refs/heads/master@{#408897}
4 years, 4 months ago (2016-08-01 01:30:56 UTC) #6
Dirk Pranke
4 years, 4 months ago (2016-08-01 02:11:03 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698