Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2192373002: Have ResizeViewportAnchor derive from GarbageCollected<> only. (Closed)

Created:
4 years, 4 months ago by sof
Modified:
4 years, 4 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have ResizeViewportAnchor derive from GarbageCollected<> only. Drop use of GarbageCollectedFinalized<>; not needed for this class. R= BUG= Committed: https://crrev.com/034ea7e22055f60a3d25d6ab833d68381b31e569 Cr-Commit-Position: refs/heads/master@{#408888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/web/ResizeViewportAnchor.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ResizeViewportAnchor.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
sof
please take a look.
4 years, 4 months ago (2016-07-31 05:26:04 UTC) #5
haraken
LGTM
4 years, 4 months ago (2016-07-31 08:30:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192373002/1
4 years, 4 months ago (2016-07-31 17:15:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-31 17:20:56 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-31 17:22:49 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/034ea7e22055f60a3d25d6ab833d68381b31e569
Cr-Commit-Position: refs/heads/master@{#408888}

Powered by Google App Engine
This is Rietveld 408576698