Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 219233002: Cleanup bootstrapper, execution and factory modules. (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer
Modified:
6 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Cleanup bootstrapper, execution and factory modules. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20349

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -236 lines) Patch
M src/bootstrapper.h View 4 chunks +10 lines, -40 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +5 lines, -38 lines 0 comments Download
M src/execution.h View 5 chunks +7 lines, -35 lines 0 comments Download
M src/execution.cc View 3 chunks +6 lines, -40 lines 0 comments Download
M src/factory.h View 3 chunks +13 lines, -44 lines 0 comments Download
M src/factory.cc View 2 chunks +5 lines, -39 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 8 months ago (2014-03-31 11:31:42 UTC) #1
Sven Panne
lgtm
6 years, 8 months ago (2014-03-31 11:33:47 UTC) #2
Benedikt Meurer
6 years, 8 months ago (2014-03-31 12:01:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20349 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698