Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2192303002: Try yet again to flip official win builders to GN. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try yet again to flip official win builders to GN. TBR=brettw@chromium.org NOTRY=true BUG=623659 Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3 Cr-Commit-Position: refs/heads/master@{#408782}

Patch Set 1 #

Patch Set 2 : make sure x86 win is x86 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M tools/mb/mb_config.pyl View 1 7 chunks +19 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Dirk Pranke
landing notry=true because the trybots won't catch this, and so we can trigger a build ...
4 years, 4 months ago (2016-07-29 22:16:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192303002/20001
4 years, 4 months ago (2016-07-29 22:16:52 UTC) #4
brettw
lgtm
4 years, 4 months ago (2016-07-29 22:17:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 22:21:47 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3 Cr-Commit-Position: refs/heads/master@{#408782}
4 years, 4 months ago (2016-07-29 22:23:35 UTC) #9
tapted
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2196993002/ by tapted@chromium.org. ...
4 years, 4 months ago (2016-08-01 00:08:35 UTC) #10
Dirk Pranke
4 years, 4 months ago (2016-08-01 02:10:00 UTC) #11
Message was sent while issue was closed.
On 2016/08/01 00:08:35, tapted wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2196993002/ by mailto:tapted@chromium.org.
> 
> The reason for reverting is: All the NaCl tests are crashing with "Actual:
> "Plugin crashed. 'NaCl module crashed" since
>
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui...
> 
> This seems to be the most likely cause :(.

Nope, this CL didn't affect those builders.

Powered by Google App Engine
This is Rietveld 408576698