Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: third_party/WebKit/Source/wtf/text/StringBuilder.cpp

Issue 2192293002: StringBuilder::append should not use reserveCapacity. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/text/StringBuilder.cpp
diff --git a/third_party/WebKit/Source/wtf/text/StringBuilder.cpp b/third_party/WebKit/Source/wtf/text/StringBuilder.cpp
index 10d09e5d7ecba08c91a4de15caf5ed4fcb8610ea..84b332a363985da7f054992cd3a08e1e43db11c8 100644
--- a/third_party/WebKit/Source/wtf/text/StringBuilder.cpp
+++ b/third_party/WebKit/Source/wtf/text/StringBuilder.cpp
@@ -200,9 +200,7 @@ void StringBuilder::append(const LChar* characters, unsigned length)
ensureBuffer16(length);
m_string = String();
- m_buffer16->reserveCapacity(m_buffer16->size() + length);
- for (size_t i = 0; i < length; ++i)
- m_buffer16->uncheckedAppend(characters[i]);
+ m_buffer16->append(characters, length);
m_length += length;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698