Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2192283002: Remove confusing unitless quirk hint (Closed)

Created:
4 years, 4 months ago by rwlbuis
Modified:
4 years, 4 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove confusing unitless quirk hint This unitless quirk hint is confusing since stroke-dasharray is an SVG attribute and for these attributes unitless quirks are always allowed. To avoid confusion remove the hint. Committed: https://crrev.com/30e9b8b599e478f340736d0cce299e4b86f7d801 Cr-Commit-Position: refs/heads/master@{#408940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
rwlbuis
PTAL.
4 years, 4 months ago (2016-08-01 01:16:20 UTC) #4
Timothy Loh
lgtm
4 years, 4 months ago (2016-08-01 02:07:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192283002/1
4 years, 4 months ago (2016-08-01 09:58:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 11:26:22 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 11:28:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30e9b8b599e478f340736d0cce299e4b86f7d801
Cr-Commit-Position: refs/heads/master@{#408940}

Powered by Google App Engine
This is Rietveld 408576698