Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2192263002: MojoMain() -> ServiceMain() (Closed)

Created:
4 years, 4 months ago by Ben Goodger (Google)
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), feature-media-reviews_chromium.org, kalyank, qsr+mojo_chromium.org, rjkroege, sadrul, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MojoMain() -> ServiceMain() R=rockot@chromium.org BUG= Committed: https://crrev.com/438daa52dbb460fc763bcefb9213c83848204380 Cr-Commit-Position: refs/heads/master@{#408778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -162 lines) Patch
M ash/mus/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/sysui/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/touch_hud/mus/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/filesystem/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/font_service/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/leveldb/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/app_driver/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mash/browser/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/browser/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mash/catalog_viewer/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mash/example/views_examples/views_examples.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mash/init/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mash/login/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mash/quick_launch/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mash/quick_launch/quick_launch.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/screenlock/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mash/session/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mash/task_viewer/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mash/webtest/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mash/webtest/webtest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/c/system/core.h View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/public/c/system/main.h View 1 chunk +0 lines, -35 lines 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_test_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/shell/background/tests/test_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A services/shell/public/c/main.h View 1 chunk +33 lines, -0 lines 0 comments Download
M services/shell/public/cpp/names.h View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/public/cpp/service_context.h View 1 chunk +2 lines, -1 line 0 comments Download
M services/shell/public/cpp/service_runner.h View 1 chunk +6 lines, -6 lines 0 comments Download
M services/shell/runner/host/native_application_support.h View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/runner/host/native_application_support.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M services/shell/tests/connect/connect_test_app.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M services/shell/tests/connect/connect_test_class_app.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M services/shell/tests/connect/connect_test_package.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M services/shell/tests/connect/connect_test_singleton_app.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M services/shell/tests/lifecycle/app.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/shell/tests/lifecycle/package.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/shell/tests/lifecycle/parent.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/shell/tests/shutdown/shutdown_client_app.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M services/shell/tests/shutdown/shutdown_service_app.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/tracing/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/ui/demo/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/ui/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/ui/service.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/test_ime/main.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/ui/test_wm/test_wm.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Ben Goodger (Google)
4 years, 4 months ago (2016-07-29 21:09:30 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 4 months ago (2016-07-29 21:18:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192263002/1
4 years, 4 months ago (2016-07-29 21:53:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 22:02:56 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 22:04:08 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/438daa52dbb460fc763bcefb9213c83848204380
Cr-Commit-Position: refs/heads/master@{#408778}

Powered by Google App Engine
This is Rietveld 408576698