Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 219223008: Revert of Revert of Put the squashing layer underneath the ancestor clipping layer if present. (Closed)

Created:
6 years, 8 months ago by chrishtr
Modified:
6 years, 8 months ago
Reviewers:
Ian Vollick, hartmanng
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Revert of Revert of Put the squashing layer underneath the ancestor clipping layer if present. (https://codereview.chromium.org/218313002/) Reason for revert: The breakage is only with --enable-universal-accelerated-overflow-scroll true. Since that feature is not launched and not tied to squashing, going to re-lad the original CL. Original issue's description: > Revert of Put the squashing layer underneath the ancestor clipping layer if present. (https://codereview.chromium.org/215823002/) > > Reason for revert: > This appears to have unexpected effects on rendering. Bits of gmail are missing for example. > > Original issue's description: > > Put the squashing layer underneath the ancestor clipping layer if present. > > > > Previously, this was the case for m_graphicsLayer but not m_squashingLayer. > > Since they now are guaranteed to have the same clipping ancestor, this is both > > safe and correct. > > > > BUG=336563 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170348 > > TBR=hartmanng@chromium.org,chrishtr@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=336563 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170413 TBR=hartmanng@chromium.org,vollick@chromium.org NOTREECHECKS=true NOTRY=true BUG=336563 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -17 lines) Patch
A LayoutTests/compositing/squashing/overflow-scroll-grandchildren.html View 1 chunk +62 lines, -0 lines 0 comments Download
A LayoutTests/compositing/squashing/overflow-scroll-grandchildren-expected.html View 1 chunk +57 lines, -0 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +14 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 3 chunks +20 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
chrishtr
Created Revert of Revert of Put the squashing layer underneath the ancestor clipping layer if ...
6 years, 8 months ago (2014-04-01 03:05:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/219223008/1
6 years, 8 months ago (2014-04-01 03:05:06 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 03:05:34 UTC) #3
Message was sent while issue was closed.
Change committed as 170507

Powered by Google App Engine
This is Rietveld 408576698