Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 219223003: Add setting for fitting the content in the viewport width (Closed)

Created:
6 years, 8 months ago by kenneth.r.christiansen
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Add setting for fitting the content in the viewport width This will be enabled for Android only, following a patch for Chromium side, effectively disabling this mobile specific behavior for desktop. BUG=359047 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170662 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170969

Patch Set 1 #

Patch Set 2 : Do not use the setting yet before Chromium side lands. #

Patch Set 3 : Part 2 #

Patch Set 4 : Fixed the inspector tests #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/web/WebDevToolsAgentImpl.cpp View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
kenneth.r.christiansen
6 years, 8 months ago (2014-03-31 12:34:47 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-02 11:28:38 UTC) #2
kenneth.r.christiansen
The CQ bit was checked by kenneth.r.christiansen@intel.com
6 years, 8 months ago (2014-04-02 11:30:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/219223003/1
6 years, 8 months ago (2014-04-02 11:30:12 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 11:47:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg tryserver.blink on mac_blink_rel
6 years, 8 months ago (2014-04-02 11:47:25 UTC) #6
kenneth.r.christiansen
Seems that I might need to turn this setting on for the unit tests. I ...
6 years, 8 months ago (2014-04-02 11:50:00 UTC) #7
kenneth.r.christiansen
The CQ bit was checked by kenneth.r.christiansen@intel.com
6 years, 8 months ago (2014-04-02 14:12:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/219223003/10001
6 years, 8 months ago (2014-04-02 14:12:54 UTC) #9
commit-bot: I haz the power
Change committed as 170662
6 years, 8 months ago (2014-04-02 15:21:11 UTC) #10
kenneth.r.christiansen
I uploaded the part that I removed from the first patch in order to enable ...
6 years, 8 months ago (2014-04-07 11:50:29 UTC) #11
kenneth.r.christiansen
The CQ bit was checked by kenneth.r.christiansen@intel.com
6 years, 8 months ago (2014-04-07 11:51:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/219223003/20001
6 years, 8 months ago (2014-04-07 11:51:35 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-07 12:25:50 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-07 12:25:50 UTC) #15
dgozman
WebDevToolsAgentImpl lgtm.
6 years, 8 months ago (2014-04-07 12:53:22 UTC) #16
kenneth.r.christiansen
The CQ bit was checked by kenneth.r.christiansen@intel.com
6 years, 8 months ago (2014-04-07 12:53:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/219223003/60001
6 years, 8 months ago (2014-04-07 12:55:08 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-07 13:22:40 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-04-07 13:22:40 UTC) #20
kenneth.r.christiansen
The CQ bit was checked by kenneth.r.christiansen@intel.com
6 years, 8 months ago (2014-04-07 13:27:45 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/219223003/60001
6 years, 8 months ago (2014-04-07 13:27:50 UTC) #22
commit-bot: I haz the power
Change committed as 170969
6 years, 8 months ago (2014-04-07 13:55:36 UTC) #23
mnaganov (inactive)
Sorry for chiming in late, but the setting for fitting the content into viewport was ...
6 years, 6 months ago (2014-06-18 15:00:28 UTC) #24
kenneth.r.christiansen
On 2014/06/18 at 15:00:28, mnaganov wrote: > Sorry for chiming in late, but the setting ...
6 years, 6 months ago (2014-06-18 15:38:47 UTC) #25
mnaganov (inactive)
On 2014/06/18 15:38:47, kenneth.r.christiansen wrote: > On 2014/06/18 at 15:00:28, mnaganov wrote: > > Sorry ...
6 years, 6 months ago (2014-06-18 16:04:16 UTC) #26
kenneth.christiansen
6 years, 6 months ago (2014-06-23 08:10:37 UTC) #27
Message was sent while issue was closed.
On 2014/06/18 16:04:16, Mikhail Naganov (Cr) wrote:

> I'm totally fine with your new name.

I created https://codereview.chromium.org/344203003

Powered by Google App Engine
This is Rietveld 408576698