Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2192213002: Allow long test names in pylintrc. (Closed)

Created:
4 years, 4 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, wkorman, mithro
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow long test names in pylintrc. Many test methods in unit tests have names much longer than 30 characters. I think this is fine for test method names, since they're meant to be descriptive, but not necessarily short and memorable. Committed: https://crrev.com/faa993577f164eb212d5b363e90180a85139ea74 Cr-Commit-Position: refs/heads/master@{#408786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/pylintrc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
qyearsley
4 years, 4 months ago (2016-07-29 16:16:38 UTC) #3
wkorman
lgtm
4 years, 4 months ago (2016-07-29 22:21:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192213002/1
4 years, 4 months ago (2016-07-29 22:23:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 22:28:27 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/faa993577f164eb212d5b363e90180a85139ea74 Cr-Commit-Position: refs/heads/master@{#408786}
4 years, 4 months ago (2016-07-29 22:31:58 UTC) #13
Dirk Pranke
4 years, 4 months ago (2016-08-09 00:45:29 UTC) #15
Message was sent while issue was closed.
lgtm also (belatedly).

Powered by Google App Engine
This is Rietveld 408576698