Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2192203002: GN: quick doc (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
hal.canary, jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix clang #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
A site/user/quick/gn.md View 1 1 chunk +42 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (6 generated)
mtklein_C
4 years, 4 months ago (2016-07-29 15:33:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192203002/20001
4 years, 4 months ago (2016-07-29 15:33:26 UTC) #6
jcgregorio
lgtm
4 years, 4 months ago (2016-07-29 15:34:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/3a880569949b16c83a9193d43c56337e04c00a87
4 years, 4 months ago (2016-07-29 15:35:57 UTC) #9
hal.canary
4 years, 4 months ago (2016-08-03 18:26:45 UTC) #11
Message was sent while issue was closed. 
https://codereview.chromium.org/2192203002/diff/20001/site/user/quick/gn.md
File site/user/quick/gn.md (right):

https://codereview.chromium.org/2192203002/diff/20001/site/user/quick/gn.md#n...
site/user/quick/gn.md:28: gclient sync && bin/fetch-gn
`bin/sync` is a good wrapper around `gclient sync`

Powered by Google App Engine
This is Rietveld 408576698