Remove .html extension from links

Remove .html extension from links

BUG=346315
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272123

[ahernandez, 2014-04-08 19:45:16]

Could you please take a look at these changes? 

mkearney@, in hosting_changes.html, none of the headers had ids, so I put some
temporary ones for now. If you could look those over and suggest better ones, it
would be much appreciated. Thank you.

[mkearney1, 2014-04-09 18:20:53]

On 2014/04/08 19:45:16, ahernandez.miralles wrote:
> Could you please take a look at these changes? 
> 
> mkearney@, in hosting_changes.html, none of the headers had ids, so I put some
> temporary ones for now. If you could look those over and suggest better ones,
it
> would be much appreciated. Thank you.

Hey,

I'm doing a full test now, but first review comment, there are two whitespace
errors:

<stdin>:896: space before tab in indent.
        <a href="declare_permissions">permissions</a>.
<stdin>:6399: trailing whitespace.
in the <a href="manifest">manifest</a> 
warning: 2 lines add whitespace errors.

[mkearney1, 2014-04-09 19:43:28]

I've worked more than a third through the files, and I'm publishing the comments
now, as you just need a couple of fixes that will stop me from having to make so
many comments.

We shouldn't remove the .html from everything-- just href. We need to keep file
references in play.

Also, we shouldn't remove .html from hrefs that are outside the files in the
developer.chrome.com domain. Specifically the links to GitHub files that end in
.html are broken.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/articles/app_codelab2_basic.html
(right):

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab2_basic.html:60:
<p>Create the user interface: <a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab2_basic/index">index</a>
Does it matter that this is a GitHub repo? I'm trying to test and getting server
errors that are unrelated.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab2_basic.html:62:
<pre data-filename="index">
Keep .html here, as it separates this from .js file in GitHub sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab2_basic.html:97: to
&quot;My first app&quot; in index.</p></li>
Keep .html here, as it's a file reference in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab2_basic.html:101:
For now, you can open index on both.</p></li>
Keep .html here as it's a file reference in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html
(right):

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html:40:
<p>Change the <a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab3_mvc/angularjs/simpleview/index">AngularJS
index</a> or
Need to make sure links work to GitHub samples without .html.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html:40:
<p>Change the <a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab3_mvc/angularjs/simpleview/index">AngularJS
index</a> or
Keep .html here as it refers to a filename for a sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html:41: <a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab3_mvc/javascript/simpleview/index">JavaScript
index</a> to use a simple sample:
Need to make sure links work to GitHub samples without .html.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html:41: <a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab3_mvc/javascript/simpleview/index">JavaScript
index</a> to use a simple sample:
Keep .html here as it refers to a filename for a sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html:50: <pre
data-filename="index">
Keep .html here as it refers to a filename for a sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html:73: <pre
data-filename="index">
Keep .html here as it refers to a filename for a sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html:322:
<p>Change the <a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab3_mvc/angularjs/withcontroller/index">AngularJS
index</a> or
Test that link works without .html to Github repo samples.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html:322:
<p>Change the <a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab3_mvc/angularjs/withcontroller/index">AngularJS
index</a> or
Keep .html here as it refers to a filename in a sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html:323: <a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab3_mvc/javascript/withcontroller/index">JavaScript
index</a>:
Again, test link works without .html to Github repo samples.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html:323: <a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab3_mvc/javascript/withcontroller/index">JavaScript
index</a>:
Keep .html here as it refers to a filename in a sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html:332: <pre
data-filename="index">
Keep .html here as it refers to a filename in a sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html:361: <pre
data-filename="index">
Keep .html here as it refers to a filename in a sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/articles/app_codelab5_data.html
(right):

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab5_data.html:118: <a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/angularjs/1_storage_sync/index">AngularJs
index.hmtl</a> or
Check if GitHub links work without .html

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab5_data.html:118: <a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/angularjs/1_storage_sync/index">AngularJs
index.hmtl</a> or
Keep .html here as it refers to a filename in a sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab5_data.html:134:
<pre data-filename="index">
Keep .html here as it refers to a filename in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab5_data.html:145:
<pre data-filename="index">
Keep .html here as it refers to a filename in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab5_data.html:325: <a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/angularjs/2_drop_files/index">AngularJS
index</a> file to make all the area of the window accept the drop event and
still work on the same scope.
Check links work to GitHub samples without .html.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab5_data.html:325: <a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/angularjs/2_drop_files/index">AngularJS
index</a> file to make all the area of the window accept the drop event and
still work on the same scope.
Keep .html here as it refers to filename in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab5_data.html:344: (in
<a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/angularjs/2_drop_files/index">AngularJS
index</a> or
Check this link works without .html.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab5_data.html:344: (in
<a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/angularjs/2_drop_files/index">AngularJS
index</a> or
Keep this .html in as it refers to a filename in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab5_data.html:345: <a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/javascript/2_drop_files/index">JavaScript
index</a>) to warn the user that some types of dragging are not allowed:
Check this link works without .html.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab5_data.html:345: <a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/javascript/2_drop_files/index">JavaScript
index</a>) to warn the user that some types of dragging are not allowed:
Keep .html in as it refers to a filename in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab5_data.html:354:
<pre data-filename="index">
Keep .html in as it refers to filename in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab5_data.html:361:
<pre data-filename="index">
Keep .html in as it refers to filename in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
File
chrome/common/extensions/docs/templates/articles/app_codelab7_useridentification.html
(right):

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab7_useridentification.html:145:
<li><p>Now we just need a button that starts the import process. Update the
<code>index</code> to include <code>gapi_tasks.js</code> and add a new button to
call <code>importFromGTasks</code>:
Keep .html in as it refers to a filename in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab7_useridentification.html:154:
<pre data-filename="index">
Keep .html in as it refers to a filename in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab7_useridentification.html:162:
&lt;button id="importGTasks"&gt;import tasks from GTasks&lt;/button&gt;
Keep .html in as it refers to a filename in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
File
chrome/common/extensions/docs/templates/articles/app_codelab8_webresources.html
(right):

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab8_webresources.html:45:
<a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab8_webresources/angularjs/1_webview/index">AngularJS
index</a> or
Dropping the .html to GitHub links doesn't seem to work.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab8_webresources.html:45:
<a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab8_webresources/angularjs/1_webview/index">AngularJS
index</a> or
Keep .html as it refers to filename in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab8_webresources.html:46:
<a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab8_webresources/javascript/1_webview/index">JavaScript
index</a>:
Dropping the .html to GitHub links doesn't seem to work.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab8_webresources.html:46:
<a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab8_webresources/javascript/1_webview/index">JavaScript
index</a>:
Keep .html as it refers to filename in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab8_webresources.html:55:
<pre data-filename="index">
Keep .html as it refers to filename in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab8_webresources.html:63:
<pre data-filename="index">
Keep .html as it refers to filename in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab8_webresources.html:144:
<p>If you try to add an <code>&lt;img&gt;</code> tag to your <code>index</code>,
and point its <code>src</code> attribute to any site on the web, the following
exception is thrown in the console and the image isn&#39;t loaded:</p>
Keep .html as it refers to filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab8_webresources.html:175:
<a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab8_webresources/angularjs/2_loading_resources/index">AngularJS
index</a> or
GitHub links without .html don't seem to work.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab8_webresources.html:175:
<a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab8_webresources/angularjs/2_loading_resources/index">AngularJS
index</a> or
Keep .html as it refers to filename in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab8_webresources.html:176:
<a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab8_webresources/javascript/2_loading_resources/index">JavaScript
index_html</a>:
GitHub links without .html don't seem to work.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab8_webresources.html:176:
<a
href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab8_webresources/javascript/2_loading_resources/index">JavaScript
index_html</a>:
Keep .html as it refers to filename in sample.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/articles/app_external.html (right):

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_external.html:100: <pre
data-filename="browser">
Keep .html as it refers to a filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_external.html:148: <pre
data-filename="sandboxed">
Keep .html as it refers to a filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_external.html:169: "pages":
["sandboxed"]
Keep .html as it refers to a filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_external.html:195:
chrome.app.window.create('window', {
Keep .html as it refers to a filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_external.html:205:
'bounds': {
Keep .html as it refers to a filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_external.html:220: <pre
data-filename="window">
Keep .html as it refers to a filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_external.html:228:
&lt;iframe src="sandboxed" width="300" height="200">&lt;/iframe>
Keep .html as it refers to a filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_external.html:257:
'bounds': {
Keep .html as it refers to a filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_external.html:290: 
Keep .html as it refers to a filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/articles/app_lifecycle.html
(right):

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_lifecycle.html:102:
chrome.app.window.create('main', {
Keep .html as it refers to a filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/articles/apps.html (right):

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/apps.html:96: "local_path":
"main"
Keep .html in as it refers to a filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/articles/autoupdate.html (right):

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/autoupdate.html:16: <a
href="http://blog.chromium.org/2013/11/protecting-windows-users-from-malicious">Protecting
Windows users from malicious extensions</a>).
Check if this link works to blogpost.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/articles/background_pages.html
(right):

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/background_pages.html:77:
"page": "background"
Keep .html in as it refers to filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/background_pages.html:120: from
a file named <code>image</code>.
Keep .html in as it refers to filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/background_pages.html:127: var
viewTabUrl = chrome.extension.getURL('image');
Keep .html in as it refers to filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/background_pages.html:146: <pre
data-filename="image">
Keep .html in as it refers to filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/articles/contentSecurityPolicy.html
(right):

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/contentSecurityPolicy.html:104:

Keep .html in as it refers to filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/contentSecurityPolicy.html:195:
<pre data-filename="popup">
Keep .html in as it refers to filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/contentSecurityPolicy.html:226:
<pre data-filename="popup">
Keep .html in as it refers to filename.

https://codereview.chromium.org/219213007/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/contentSecurityPolicy.html:243:
<pre data-filename="popup">
Keep .html in as it refers to filename.

[ahernandez, 2014-04-09 20:03:32]

I see, I should have known better than to just run sed on the files, I apologize
for unnecessarily making you go through so many of these.

kalman@, is the broken link detector destined to never be resurrected? It
certainly would have been useful in this situation.

[not at google - send to devlin, 2014-04-09 20:04:57]

I would love for it to be resurrected but it's just too slow at the moment, and
I haven't thought much about how to speed it up.

Worth mentioning to Jared.

[mkearney, 2014-04-09 20:07:30]

No worries. That's what reviews are for, and glad to have you working on
the doc server!


On Wed, Apr 9, 2014 at 1:03 PM, <ahernandez.miralles@gmail.com> wrote:

> I see, I should have known better than to just run sed on the files, I
> apologize
> for unnecessarily making you go through so many of these.
>
> kalman@, is the broken link detector destined to never be resurrected? It
> certainly would have been useful in this situation.
>
>
> https://codereview.chromium.org/219213007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[ahernandez, 2014-04-15 17:10:07]

I've changed the files to only have the .html extension removed from references.
PTAL

[mkearney1, 2014-04-21 23:09:36]

So first review comment I went to test is still not fixed.

Can you check review comments and see how they stack up to fix? 

Thanks. It's kind of manual-- but you will see patterns quickly.

[mkearney1, 2014-04-21 23:11:33]

On 2014/04/21 23:09:36, mkearney1 wrote:
> So first review comment I went to test is still not fixed.
> 
> Can you check review comments and see how they stack up to fix? 
> 
> Thanks. It's kind of manual-- but you will see patterns quickly.

Whoops-- Totally disregard my last comment. I was reviewing the old patch! Dope.

Sorry-- looking at latest patch now :)

[ahernandez, 2014-05-13 17:33:44]

Is this still being looked at?

[not at google - send to devlin, 2014-05-13 17:35:56]

It should be, it must have slipped past Meggin.

Ping after a few days, not after a few weeks :)

[chromium-reviews, 2014-05-13 17:41:04]

Hey,

I worked mostly through this cl, but keep getting side-tracked (it takes a
long time to test this).

I will finish it today.

Meggin


On Tue, May 13, 2014 at 10:35 AM, <kalman@chromium.org> wrote:

> It should be, it must have slipped past Meggin.
>
> Ping after a few days, not after a few weeks :)
>
> https://codereview.chromium.org/219213007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2014-05-13 23:16:28]

I spoke too soon-- I will finish tomorrow on the bus ride in.


On Tue, May 13, 2014 at 10:41 AM, Meggin Kearney <mkearney@google.com>wrote:

> Hey,
>
> I worked mostly through this cl, but keep getting side-tracked (it takes a
> long time to test this).
>
> I will finish it today.
>
> Meggin
>
>
> On Tue, May 13, 2014 at 10:35 AM, <kalman@chromium.org> wrote:
>
>> It should be, it must have slipped past Meggin.
>>
>> Ping after a few days, not after a few weeks :)
>>
>> https://codereview.chromium.org/219213007/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mkearney1, 2014-05-14 19:56:05]

lgtm once below are addressed.

https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/articles/app_codelab5_data.html
(right):

https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/app_codelab5_data.html:410:
<p>The current code only saves the file reference, but it doesn&#39;t open the
file. Using the <a
href="http://www.html5rocks.com/en/tutorials/file/filesystem/">HTML5 Filesystem
API</a>, save the file contents in a sandboxed filesystem. When the Todo item is
archived, remove the corresponding file from the sandboxed filesystem. Add an
&quot;open&quot; link on each Todo that has an associated file. When the item is
clicked and the file exists in the sandboxed filesystem, use the Chrome App <a
href="fileSystem.html">Filesystem API</a> to request a writable FileEntry from
the user. Save the file data from the sandboxed filesystem into that entry.</p>
You don't need .html in <a href="fileSystem.html">Filesystem API</a>.

https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/articles/apps.html (right):

https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/apps.html:73: <li> <a
href="http://code.google.com/chrome/apps/articles/thinking_in_web_apps">Thinking
in Web Apps</a> </li>
Keep .html here, especially since similar links have it. I wonder if these links
still work, on an side, as it's code.google.com.

https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/articles/hosting_changes.html
(right):

https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/hosting_changes.html:1:
<h1>Chrome 33 Hosting Changes</h1>
General question: when removing the header IDs, what will happen to urls that
link to these? I've included another comment in this doc that is an example of
this.

https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/hosting_changes.html:55: <a
href="http://developer.chrome.com/extensions/getstarted#unpacked">developer
mode</a>
Will this link still work if you remove "unpacked" id?

https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/private/permissions/background.html
(right):

https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
chrome/common/extensions/docs/templates/private/permissions/background.html:14:
You typically use the "background" permission with a <a
href="background_pages">background page</a>, <a href="event_pages">event
page</a> or (for hosted apps) a <a
href="http://code.google.com/chrome/apps/docs/background.html">background
window</a>.
I'm guessing http://code.google.com/chrome/apps/docs/background.html is a broken
link. Can we fix it?

[ahernandez, 2014-05-14 20:13:44]

mkearney@, did the header ids I added in hosting_changes.html look fine then?

kalman@, did you need to review anything specifically? I can't remember why I
added you as a reviewer.

https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/articles/hosting_changes.html
(right):

https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/hosting_changes.html:1:
<h1>Chrome 33 Hosting Changes</h1>
On 2014/05/14 19:56:06, mkearney1 wrote:
> General question: when removing the header IDs, what will happen to urls that
> link to these? I've included another comment in this doc that is an example of
> this.

I don't think I quite understand your question. There shouldn't be any urls that
link to these headers since they don't exist in the current code base, if that's
what you mean.

https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/hosting_changes.html:55: <a
href="http://developer.chrome.com/extensions/getstarted#unpacked">developer
mode</a>
On 2014/05/14 19:56:06, mkearney1 wrote:
> Will this link still work if you remove "unpacked" id?

If I remove 'id="unpacked"', the link will still work since it's linking to a
different file.

https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/private/permissions/background.html
(right):

https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
chrome/common/extensions/docs/templates/private/permissions/background.html:14:
You typically use the "background" permission with a <a
href="background_pages">background page</a>, <a href="event_pages">event
page</a> or (for hosted apps) a <a
href="http://code.google.com/chrome/apps/docs/background.html">background
window</a>.
On 2014/05/14 19:56:06, mkearney1 wrote:
> I'm guessing http://code.google.com/chrome/apps/docs/background.html is a
broken
> link. Can we fix it?

That link works for me

[not at google - send to devlin, 2014-05-14 20:24:17]

i'm happy to let meggin take this. let me know if you need a rubber stamp.

[mkearney1, 2014-05-14 22:04:34]

On 2014/05/14 20:13:44, ahernandez.miralles wrote:
> mkearney@, did the header ids I added in hosting_changes.html look fine then?
> 
> kalman@, did you need to review anything specifically? I can't remember why I
> added you as a reviewer.
> 
>
https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
> File chrome/common/extensions/docs/templates/articles/hosting_changes.html
> (right):
> 
>
https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
> chrome/common/extensions/docs/templates/articles/hosting_changes.html:1:
> <h1>Chrome 33 Hosting Changes</h1>
> On 2014/05/14 19:56:06, mkearney1 wrote:
> > General question: when removing the header IDs, what will happen to urls
that
> > link to these? I've included another comment in this doc that is an example
of
> > this.
> 
> I don't think I quite understand your question. There shouldn't be any urls
that
> link to these headers since they don't exist in the current code base, if
that's
> what you mean.
> 
>
https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
> chrome/common/extensions/docs/templates/articles/hosting_changes.html:55: <a
> href="http://developer.chrome.com/extensions/getstarted#unpacked">developer
> mode</a>
> On 2014/05/14 19:56:06, mkearney1 wrote:
> > Will this link still work if you remove "unpacked" id?
> 
> If I remove 'id="unpacked"', the link will still work since it's linking to a
> different file.
> 
>
https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
> File
chrome/common/extensions/docs/templates/private/permissions/background.html
> (right):
> 
>
https://codereview.chromium.org/219213007/diff/40001/chrome/common/extensions...
>
chrome/common/extensions/docs/templates/private/permissions/background.html:14:
> You typically use the "background" permission with a <a
> href="background_pages">background page</a>, <a href="event_pages">event
> page</a> or (for hosted apps) a <a
> href="http://code.google.com/chrome/apps/docs/background.html">background
> window</a>.
> On 2014/05/14 19:56:06, mkearney1 wrote:
> > I'm guessing http://code.google.com/chrome/apps/docs/background.html is a
> broken
> > link. Can we fix it?
> 
> That link works for me

Hey, I'm good with the header ids for hosting_changes (I think I got myself
mixed up-- the ids need to be there, and they are, as you added them in. 

In terms of the link, can you update it to this:
https://developers.google.com/chrome/apps/docs/background ?

I realize it works, but it might not for long, as code.google.com is being
decommissioned totally and even redirects have been breaking.

[ahernandez, 2014-05-21 21:02:44]

mkearney@, I addressed the comments you left. Would you like me to upload
another patch converting code.google.com links to developers.google.com?

[chromium-reviews, 2014-05-21 21:03:19]

Yep, upload.


On Wed, May 21, 2014 at 2:02 PM, <ahernandez.miralles@gmail.com> wrote:

> mkearney@, I addressed the comments you left. Would you like me to upload
> another patch converting code.google.com links to developers.google.com?
>
> https://codereview.chromium.org/219213007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[ahernandez, 2014-05-21 21:03:36]

The CQ bit was checked by ahernandez.miralles@gmail.com

[commit-bot: I haz the power, 2014-05-21 21:08:29]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/ahernandez.miralles@gmail.com/21921300...

[commit-bot: I haz the power, 2014-05-21 21:08:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-21 21:08:33]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[ahernandez, 2014-05-21 21:19:47]

kalman@, looks like I need a rubber stamp?

[not at google - send to devlin, 2014-05-21 22:05:34]

lgtm

[ahernandez, 2014-05-21 22:11:05]

The CQ bit was checked by ahernandez.miralles@gmail.com

[commit-bot: I haz the power, 2014-05-21 22:14:59]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/ahernandez.miralles@gmail.com/21921300...

[commit-bot: I haz the power, 2014-05-22 06:35:56]

Change committed as 272123