Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2192113002: X87: Revert of [heap] Reland "Remove black pages and use black areas instead." (patchset #4 id:6000… (Closed)

Created:
4 years, 4 months ago by zhengxing.li
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Revert of [heap] Reland "Remove black pages and use black areas instead." (patchset #4 id:60001 of https://codereview.chromium.org/2185613002/ ). port 2c7efba658e6f48e115c7ff17d1d1053e5825e06 (r38129) original commit message: Reason for revert: Still crashing. Original issue's description: > [heap] Reland "Remove black pages and use black areas instead." > > BUG=chromium:630969, chromium:630386 > LOG=n > > Committed: https://crrev.com/9e37a07c8de0a20ef2681e26824ff4d329102603 > Cr-Commit-Position: refs/heads/master@{#38057} BUG= Committed: https://crrev.com/9429ec9cdd682db80914001eb65ed94c1a2c5cf0 Cr-Commit-Position: refs/heads/master@{#38152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/x87/assembler-x87-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 4 months ago (2016-07-29 01:59:12 UTC) #2
Weiliang
lgtm
4 years, 4 months ago (2016-07-29 02:14:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192113002/1
4 years, 4 months ago (2016-07-29 02:15:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 02:37:25 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 02:40:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9429ec9cdd682db80914001eb65ed94c1a2c5cf0
Cr-Commit-Position: refs/heads/master@{#38152}

Powered by Google App Engine
This is Rietveld 408576698