Implement resize option for createImageBitmap(HTMLVideoElement)

Implement resize option for createImageBitmap(HTMLVideoElement)

Without resize, this function works like this:
It creates a ImageBuffer, and calls video->paintCurrentFrame to the
SkCanvas backed by the buffer, then it calls buffer's snapshot to get
a SkImage. To make resize efficient, we just need to carefully calculate
the parameter for the video->paintCurrentFrame, and we can do the resize
in one pass.

BUG=627855
Committed: https://crrev.com/2fb8cdf52aabd723d1cf9724a4814cda98078fb8
Cr-Commit-Position: refs/heads/master@{#408850}

[xidachen, 2016-07-29 12:13:30]

xidachen@chromium.org changed reviewers:
+ junov@chromium.org

[xidachen, 2016-07-29 12:13:31]

PTAL

[Justin Novosad, 2016-07-29 15:08:52]

https://codereview.chromium.org/2192103002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/ImageBitmap.cpp (right):

https://codereview.chromium.org/2192103002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:333:
dstPoint.scale(parsedOptions.scaleRatioX, parsedOptions.scaleRatioY);
putting the scaleRAtion in parsedOptions is overkill IMHO.  they should just be
locals in this function. It adds unnecessary complexity to the shared parsing
function.  Not to mention that the bool arg is bad for readability.

[xidachen, 2016-07-29 17:22:11]

https://codereview.chromium.org/2192103002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/ImageBitmap.cpp (right):

https://codereview.chromium.org/2192103002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:333:
dstPoint.scale(parsedOptions.scaleRatioX, parsedOptions.scaleRatioY);
On 2016/07/29 15:08:52, Justin Novosad wrote:
> putting the scaleRAtion in parsedOptions is overkill IMHO.  they should just
be
> locals in this function. It adds unnecessary complexity to the shared parsing
> function.  Not to mention that the bool arg is bad for readability.

Yes, that makes perfect sense. Changed in the new PS.

[Justin Novosad, 2016-07-30 00:32:03]

lgtm

[xidachen, 2016-07-30 01:19:04]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 01:19:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xidachen, 2016-07-30 02:05:11]

The CQ bit was unchecked by xidachen@chromium.org

[xidachen, 2016-07-30 02:06:21]

The CQ bit was checked by xidachen@chromium.org

[commit-bot: I haz the power, 2016-07-30 02:06:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 02:53:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-30 02:54:36]

Description was changed from

==========
Implement resize option for createImageBitmap(HTMLVideoElement)

Without resize, this function works like this:
It creates a ImageBuffer, and calls video->paintCurrentFrame to the
SkCanvas backed by the buffer, then it calls buffer's snapshot to get
a SkImage. To make resize efficient, we just need to carefully calculate
the parameter for the video->paintCurrentFrame, and we can do the resize
in one pass.

BUG=627855
==========

to

==========
Implement resize option for createImageBitmap(HTMLVideoElement)

Without resize, this function works like this:
It creates a ImageBuffer, and calls video->paintCurrentFrame to the
SkCanvas backed by the buffer, then it calls buffer's snapshot to get
a SkImage. To make resize efficient, we just need to carefully calculate
the parameter for the video->paintCurrentFrame, and we can do the resize
in one pass.

BUG=627855

Committed: https://crrev.com/2fb8cdf52aabd723d1cf9724a4814cda98078fb8
Cr-Commit-Position: refs/heads/master@{#408850}
==========

[commit-bot: I haz the power, 2016-07-30 02:54:37]

Patchset 2 (id:??) landed as
https://crrev.com/2fb8cdf52aabd723d1cf9724a4814cda98078fb8
Cr-Commit-Position: refs/heads/master@{#408850}