Background Tracing: Remove safety check for crash exit on Android

Background Tracing: Remove safety check for crash exit on Android

On Android the exit status is always marked as EXIT_CRASHED. So, the
background traces are never uploaded. Since the check is useful only for
preemptive mode, this CL removes this check for REACTIVE triggers on
Android and adds extra check for preemptive trigger in that place.

BUG=613198
Committed: https://crrev.com/61d80b31a3f83987b8a7eab9f812fbb56f330658
Cr-Commit-Position: refs/heads/master@{#408771}

[ssid, 2016-07-29 01:00:49]

Description was changed from

==========
Backgroun Tracing: Remove safety check for crash exit on Android

On Android the exit status is always marked as EXIT_CRASHED. So, the
background traces are never uploaded. Since the check is useful only for
preemptive mode, this CL removes this check for REACTIVE triggers on
Android and adds extra check for preemptive trigger in that place.

BUG=
==========

to

==========
Background Tracing: Remove safety check for crash exit on Android

On Android the exit status is always marked as EXIT_CRASHED. So, the
background traces are never uploaded. Since the check is useful only for
preemptive mode, this CL removes this check for REACTIVE triggers on
Android and adds extra check for preemptive trigger in that place.

BUG=
==========

[ssid, 2016-07-29 01:03:12]

ssid@chromium.org changed reviewers:
+ simonhatch@chromium.org

[ssid, 2016-07-29 01:03:13]

Seems like more than 99% of the background traces on Android do not get
uploaded.
https://uma.googleplex.com/p/chrome/variations/?sid=7c2ac575a99356748df27432f...

Do you think this will fix the issue?

[oystein (OOO til 10th of July), 2016-07-29 09:16:18]

oysteine@chromium.org changed reviewers:
+ oysteine@chromium.org

[oystein (OOO til 10th of July), 2016-07-29 09:16:18]

Great catch! lgtm!

[shatch, 2016-07-29 14:30:02]

lgtm

[ssid, 2016-07-29 20:38:26]

The CQ bit was checked by ssid@chromium.org

[commit-bot: I haz the power, 2016-07-29 20:39:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ssid, 2016-07-29 20:40:30]

Description was changed from

==========
Background Tracing: Remove safety check for crash exit on Android

On Android the exit status is always marked as EXIT_CRASHED. So, the
background traces are never uploaded. Since the check is useful only for
preemptive mode, this CL removes this check for REACTIVE triggers on
Android and adds extra check for preemptive trigger in that place.

BUG=
==========

to

==========
Background Tracing: Remove safety check for crash exit on Android

On Android the exit status is always marked as EXIT_CRASHED. So, the
background traces are never uploaded. Since the check is useful only for
preemptive mode, this CL removes this check for REACTIVE triggers on
Android and adds extra check for preemptive trigger in that place.

BUG=613198
==========

[commit-bot: I haz the power, 2016-07-29 21:30:05]

Description was changed from

==========
Background Tracing: Remove safety check for crash exit on Android

On Android the exit status is always marked as EXIT_CRASHED. So, the
background traces are never uploaded. Since the check is useful only for
preemptive mode, this CL removes this check for REACTIVE triggers on
Android and adds extra check for preemptive trigger in that place.

BUG=613198
==========

to

==========
Background Tracing: Remove safety check for crash exit on Android

On Android the exit status is always marked as EXIT_CRASHED. So, the
background traces are never uploaded. Since the check is useful only for
preemptive mode, this CL removes this check for REACTIVE triggers on
Android and adds extra check for preemptive trigger in that place.

BUG=613198
==========

[commit-bot: I haz the power, 2016-07-29 21:30:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-29 21:31:17]

Description was changed from

==========
Background Tracing: Remove safety check for crash exit on Android

On Android the exit status is always marked as EXIT_CRASHED. So, the
background traces are never uploaded. Since the check is useful only for
preemptive mode, this CL removes this check for REACTIVE triggers on
Android and adds extra check for preemptive trigger in that place.

BUG=613198
==========

to

==========
Background Tracing: Remove safety check for crash exit on Android

On Android the exit status is always marked as EXIT_CRASHED. So, the
background traces are never uploaded. Since the check is useful only for
preemptive mode, this CL removes this check for REACTIVE triggers on
Android and adds extra check for preemptive trigger in that place.

BUG=613198

Committed: https://crrev.com/61d80b31a3f83987b8a7eab9f812fbb56f330658
Cr-Commit-Position: refs/heads/master@{#408771}
==========

[commit-bot: I haz the power, 2016-07-29 21:31:18]

Patchset 1 (id:??) landed as
https://crrev.com/61d80b31a3f83987b8a7eab9f812fbb56f330658
Cr-Commit-Position: refs/heads/master@{#408771}