Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1702)

Unified Diff: net/socket/ssl_client_socket_impl.cc

Issue 2192053002: Metric & meta-metric for CECPQ1 handshake latency. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_impl.cc
diff --git a/net/socket/ssl_client_socket_impl.cc b/net/socket/ssl_client_socket_impl.cc
index e00ac6b13fa7ba3bb711229eb2e85a90aca470fb..0cb0d78242e6cbefdd5d21fcc34a8f3aee557097 100644
--- a/net/socket/ssl_client_socket_impl.cc
+++ b/net/socket/ssl_client_socket_impl.cc
@@ -17,7 +17,6 @@
#include "base/bind.h"
#include "base/callback_helpers.h"
-#include "base/feature_list.h"
#include "base/lazy_instance.h"
#include "base/macros.h"
#include "base/memory/singleton.h"
@@ -86,11 +85,6 @@ const uint8_t kTbProtocolVersionMinor = 8;
const uint8_t kTbMinProtocolVersionMajor = 0;
const uint8_t kTbMinProtocolVersionMinor = 6;
-#if !defined(OS_NACL)
-const base::Feature kPostQuantumExperiment{"SSLPostQuantumExperiment",
- base::FEATURE_DISABLED_BY_DEFAULT};
-#endif
-
bool EVP_MDToPrivateKeyHash(const EVP_MD* md, SSLPrivateKey::Hash* hash) {
switch (EVP_MD_type(md)) {
case NID_md5_sha1:
@@ -1005,8 +999,7 @@ int SSLClientSocketImpl::Init() {
// supported. As DHE is being deprecated, don't add a cipher only to remove it
// immediately.
std::string command;
-#if !defined(OS_NACL)
- if (base::FeatureList::IsEnabled(kPostQuantumExperiment)) {
+ if (SSLClientSocket::IsPostQuantumExperimentEnabled()) {
// These are experimental, non-standard ciphersuites. They are part of an
// experiment in post-quantum cryptography. They're not intended to
// represent a de-facto standard, and will be removed from BoringSSL in
@@ -1025,7 +1018,6 @@ int SSLClientSocketImpl::Init() {
"CECPQ1-ECDSA-AES256-GCM-SHA384:");
}
}
-#endif
command.append("ALL:!SHA256:!SHA384:!DHE-RSA-AES256-GCM-SHA384:!aPSK:!RC4");
if (ssl_config_.require_ecdhe)

Powered by Google App Engine
This is Rietveld 408576698