Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: impl/memory/datastore_query.go

Issue 2192003003: GAE CL for luci-go common refactor (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « impl/memory/datastore_index_selection.go ('k') | impl/memory/datastore_query_execution.go » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The LUCI Authors. All rights reserved. 1 // Copyright 2015 The LUCI Authors. All rights reserved.
2 // Use of this source code is governed under the Apache License, Version 2.0 2 // Use of this source code is governed under the Apache License, Version 2.0
3 // that can be found in the LICENSE file. 3 // that can be found in the LICENSE file.
4 4
5 package memory 5 package memory
6 6
7 import ( 7 import (
8 "bytes" 8 "bytes"
9 "encoding/base64" 9 "encoding/base64"
10 "errors" 10 "errors"
11 "fmt" 11 "fmt"
12 12
13 ds "github.com/luci/gae/service/datastore" 13 ds "github.com/luci/gae/service/datastore"
14 "github.com/luci/gae/service/datastore/serialize" 14 "github.com/luci/gae/service/datastore/serialize"
15 » "github.com/luci/luci-go/common/cmpbin" 15 » "github.com/luci/luci-go/common/data/cmpbin"
16 » "github.com/luci/luci-go/common/stringset" 16 » "github.com/luci/luci-go/common/data/stringset"
17 ) 17 )
18 18
19 // MaxQueryComponents was lifted from a hard-coded constant in dev_appserver. 19 // MaxQueryComponents was lifted from a hard-coded constant in dev_appserver.
20 // No idea if it's a real limit or just a convenience in the current dev 20 // No idea if it's a real limit or just a convenience in the current dev
21 // appserver implementation. 21 // appserver implementation.
22 const MaxQueryComponents = 100 22 const MaxQueryComponents = 100
23 23
24 // MaxIndexColumns is the maximum number of index columns we're willing to 24 // MaxIndexColumns is the maximum number of index columns we're willing to
25 // support. 25 // support.
26 const MaxIndexColumns = 64 26 const MaxIndexColumns = 64
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 // and the new value has overflowed this representation. 270 // and the new value has overflowed this representation.
271 // 271 //
272 // Fortunately, the first byte of a serialized index column entr y is a 272 // Fortunately, the first byte of a serialized index column entr y is a
273 // PropertyType byte, and the only valid values that we'll be in crementing 273 // PropertyType byte, and the only valid values that we'll be in crementing
274 // are never equal to 0xFF, since they have the high bit set (so either they're 274 // are never equal to 0xFF, since they have the high bit set (so either they're
275 // 0x8*, or 0x7*, depending on if it's inverted). 275 // 0x8*, or 0x7*, depending on if it's inverted).
276 impossible(fmt.Errorf("incrementing %v would require more sigfig s", bstr)) 276 impossible(fmt.Errorf("incrementing %v would require more sigfig s", bstr))
277 } 277 }
278 return ret 278 return ret
279 } 279 }
OLDNEW
« no previous file with comments | « impl/memory/datastore_index_selection.go ('k') | impl/memory/datastore_query_execution.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698