cc : Use dynamically calculated target space transforms

cc : Use dynamically calculated target space transforms

In ComputeTransformToTarget and ComputeTransformFromTarget. This is
turned on only when verify_transform_tree_calculations is true (only
cc_unittests as of now) and when target is an ancestor (as that's
the only case dynamically calculated target space transforms support
right now)
This CL also sets verify_transform_tree_calculations and
verify_clip_tree_calculations in some tests.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/853306aff63fc6a361ecc46589e1bf3f776214bf
Cr-Commit-Position: refs/heads/master@{#408723}

[jaydasika, 2016-07-28 22:10:23]

Description was changed from

==========
cc : Use dynamically calculated target space transforms

In ComputeTransformToTarget and ComputeTransformFromTarget. This is
turned on only when verify_transform_tree_calculations is true (only
cc_unittests as of now) and when target is an ancestor (as that's
the only case dynamically calculated target space transforms support
right now)

BUG=622372
==========

to

==========
cc : Use dynamically calculated target space transforms

In ComputeTransformToTarget and ComputeTransformFromTarget. This is
turned on only when verify_transform_tree_calculations is true (only
cc_unittests as of now) and when target is an ancestor (as that's
the only case dynamically calculated target space transforms support
right now)

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-07-28 22:55:20]

Description was changed from

==========
cc : Use dynamically calculated target space transforms

In ComputeTransformToTarget and ComputeTransformFromTarget. This is
turned on only when verify_transform_tree_calculations is true (only
cc_unittests as of now) and when target is an ancestor (as that's
the only case dynamically calculated target space transforms support
right now)

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Use dynamically calculated target space transforms

In ComputeTransformToTarget and ComputeTransformFromTarget. This is
turned on only when verify_transform_tree_calculations is true (only
cc_unittests as of now) and when target is an ancestor (as that's
the only case dynamically calculated target space transforms support
right now)
This CL aso sets verify_transform_tree_calculations and
verify_clip_tree_calculations in some tests.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-07-28 22:55:30]

Description was changed from

==========
cc : Use dynamically calculated target space transforms

In ComputeTransformToTarget and ComputeTransformFromTarget. This is
turned on only when verify_transform_tree_calculations is true (only
cc_unittests as of now) and when target is an ancestor (as that's
the only case dynamically calculated target space transforms support
right now)
This CL aso sets verify_transform_tree_calculations and
verify_clip_tree_calculations in some tests.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Use dynamically calculated target space transforms

In ComputeTransformToTarget and ComputeTransformFromTarget. This is
turned on only when verify_transform_tree_calculations is true (only
cc_unittests as of now) and when target is an ancestor (as that's
the only case dynamically calculated target space transforms support
right now)
This CL also sets verify_transform_tree_calculations and
verify_clip_tree_calculations in some tests.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-07-28 22:55:55]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, weiliangc@google.com

[jaydasika, 2016-07-28 22:55:56]

PTAL

https://codereview.chromium.org/2191983002/diff/20001/cc/trees/draw_property_...
File cc/trees/draw_property_utils.cc (right):

https://codereview.chromium.org/2191983002/diff/20001/cc/trees/draw_property_...
cc/trees/draw_property_utils.cc:807: clip_node->target_transform_id,
parent_clip_node->target_effect_id,
I am changing it to force it to take the dynamically calculated value
path(otherwise they are equivalent). This is the inverse of surface draw
transform, so I think it makes more sense to compute from target.(which is most
likely already in the cache as we would have calculated in in
SetSurfaceDrawTransform).

[jaydasika, 2016-07-28 22:56:42]

jaydasika@chromium.org changed reviewers:
+ weiliangc@chromium.org
- weiliangc@google.com

[jaydasika, 2016-07-28 23:01:13]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 23:01:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 00:03:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 00:03:45]

Dry run: This issue passed the CQ dry run.

[jaydasika, 2016-07-29 17:06:10]

Added DCHECK to make sure old and new computations are same.

[ajuma, 2016-07-29 18:03:18]

https://codereview.chromium.org/2191983002/diff/40001/cc/trees/property_tree.cc
File cc/trees/property_tree.cc (right):

https://codereview.chromium.org/2191983002/diff/40001/cc/trees/property_tree....
cc/trees/property_tree.cc:2014: DCHECK(expected.ApproximatelyEqual(*transform));
Since this has a relatively large tolerance for errors in the translation
component (it lets them be off by 1), I'd rather that the returned |transform|
be the value computed the old way, since that's still what is used outside of
tests (to avoid situations where we accidentally introduce an off-by-1 error in
the non-test code but have no test coverage to catch it).

https://codereview.chromium.org/2191983002/diff/40001/cc/trees/property_tree....
cc/trees/property_tree.cc:2045: effect_node->surface_contents_scale.y());
Same comment here about setting |transform| to the value computed the old way.

[jaydasika, 2016-07-29 18:20:16]

https://codereview.chromium.org/2191983002/diff/40001/cc/trees/property_tree.cc
File cc/trees/property_tree.cc (right):

https://codereview.chromium.org/2191983002/diff/40001/cc/trees/property_tree....
cc/trees/property_tree.cc:2014: DCHECK(expected.ApproximatelyEqual(*transform));
On 2016/07/29 18:03:18, ajuma wrote:
> Since this has a relatively large tolerance for errors in the translation
> component (it lets them be off by 1), I'd rather that the returned |transform|
> be the value computed the old way, since that's still what is used outside of
> tests (to avoid situations where we accidentally introduce an off-by-1 error
in
> the non-test code but have no test coverage to catch it).

Done.

https://codereview.chromium.org/2191983002/diff/40001/cc/trees/property_tree....
cc/trees/property_tree.cc:2045: effect_node->surface_contents_scale.y());
On 2016/07/29 18:03:18, ajuma wrote:
> Same comment here about setting |transform| to the value computed the old way.

Done.

[ajuma, 2016-07-29 18:24:51]

Thanks, lgtm

[jaydasika, 2016-07-29 18:25:15]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-07-29 18:25:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 19:29:29]

Description was changed from

==========
cc : Use dynamically calculated target space transforms

In ComputeTransformToTarget and ComputeTransformFromTarget. This is
turned on only when verify_transform_tree_calculations is true (only
cc_unittests as of now) and when target is an ancestor (as that's
the only case dynamically calculated target space transforms support
right now)
This CL also sets verify_transform_tree_calculations and
verify_clip_tree_calculations in some tests.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Use dynamically calculated target space transforms

In ComputeTransformToTarget and ComputeTransformFromTarget. This is
turned on only when verify_transform_tree_calculations is true (only
cc_unittests as of now) and when target is an ancestor (as that's
the only case dynamically calculated target space transforms support
right now)
This CL also sets verify_transform_tree_calculations and
verify_clip_tree_calculations in some tests.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-07-29 19:29:30]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2016-07-29 19:31:31]

Description was changed from

==========
cc : Use dynamically calculated target space transforms

In ComputeTransformToTarget and ComputeTransformFromTarget. This is
turned on only when verify_transform_tree_calculations is true (only
cc_unittests as of now) and when target is an ancestor (as that's
the only case dynamically calculated target space transforms support
right now)
This CL also sets verify_transform_tree_calculations and
verify_clip_tree_calculations in some tests.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Use dynamically calculated target space transforms

In ComputeTransformToTarget and ComputeTransformFromTarget. This is
turned on only when verify_transform_tree_calculations is true (only
cc_unittests as of now) and when target is an ancestor (as that's
the only case dynamically calculated target space transforms support
right now)
This CL also sets verify_transform_tree_calculations and
verify_clip_tree_calculations in some tests.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/853306aff63fc6a361ecc46589e1bf3f776214bf
Cr-Commit-Position: refs/heads/master@{#408723}
==========

[commit-bot: I haz the power, 2016-07-29 19:31:33]

Patchset 4 (id:??) landed as
https://crrev.com/853306aff63fc6a361ecc46589e1bf3f776214bf
Cr-Commit-Position: refs/heads/master@{#408723}