Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 219193017: [MIPS] Add missing mips.nexe entries in nmf (Closed)

Created:
6 years, 8 months ago by petarj
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[MIPS] Add missing mips.nexe entries in nmf Browser expects to know paths to mips native client executables, so these need to be provided in manifest files. Lack of these causes the related browser tests to fail on MIPS arch. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M chrome/test/data/nacl/bad/partly_invalid.nmf View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/nacl/bad/ppapi_bad_doesnotexist.nmf View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/nacl/bad/ppapi_bad_magic.nmf View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/nacl/bad/ppapi_bad_manifest_bad_files.nmf View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/nacl/bad/ppapi_bad_manifest_uses_nexes.nmf View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/nacl/cross_origin/cors.nmf View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/nacl/extension_mime_handler/manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/nacl/manifest/mdir/relative.nmf View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/tests/ppapi_nacl_tests_newlib.nmf View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
petarj
PTAL.
6 years, 8 months ago (2014-04-02 17:42:47 UTC) #1
Nick Bray (chromium)
LGTM, but the BUG and TEST lines are being misused. Typically BUG points to a ...
6 years, 8 months ago (2014-04-02 17:47:12 UTC) #2
petarj
The CQ bit was checked by petarj@mips.com
6 years, 8 months ago (2014-04-02 18:23:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/219193017/1
6 years, 8 months ago (2014-04-02 18:23:15 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 18:52:36 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=59117
6 years, 8 months ago (2014-04-02 18:52:36 UTC) #6
petarj
On 2014/04/02 18:52:36, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 8 months ago (2014-04-02 22:30:42 UTC) #7
bbudge
lgtm
6 years, 8 months ago (2014-04-03 12:46:44 UTC) #8
petarj
The CQ bit was checked by petarj@mips.com
6 years, 8 months ago (2014-04-03 13:49:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/219193017/1
6 years, 8 months ago (2014-04-03 13:49:57 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 16:22:48 UTC) #11
Message was sent while issue was closed.
Change committed as 261439

Powered by Google App Engine
This is Rietveld 408576698