Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 219193007: Add missing attributes to functions which we export for ASan. (Closed)

Created:
6 years, 8 months ago by earthdok
Modified:
6 years, 8 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Visibility:
Public.

Description

Add missing attributes to functions which we export for ASan. The linker was complaining. BUG=302040 R=mseaborn@chromium.org TBR=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260584

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M components/nacl/loader/nacl_helper_linux.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/xdisplaycheck/xdisplaycheck.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
earthdok
ptal
6 years, 8 months ago (2014-03-31 16:40:52 UTC) #1
Mark Seaborn
LGTM
6 years, 8 months ago (2014-03-31 16:45:26 UTC) #2
earthdok
6 years, 8 months ago (2014-03-31 17:25:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r260584 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698