Custom pseudo element types as an invalidation set feature.

Source/core/css/RuleFeature.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
@@ skipping 36 matching lines @@
         || selector.isAttributeSelector())
         return true;
     if (selector.m_match == CSSSelector::PseudoElement) {
         switch (selector.pseudoType()) {
         case CSSSelector::PseudoBefore:
         case CSSSelector::PseudoAfter:
         case CSSSelector::PseudoBackdrop:
         case CSSSelector::PseudoShadow:
             return true;
         default:
-            return false;
+            return selector.isCustomPseudoElement();
         }
     }
     if (selector.m_match != CSSSelector::PseudoClass)
         return false;
     switch (selector.pseudoType()) {
     case CSSSelector::PseudoEmpty:
     case CSSSelector::PseudoFirstChild:
     case CSSSelector::PseudoFirstOfType:
     case CSSSelector::PseudoLastChild:
     case CSSSelector::PseudoLastOfType:
@@ skipping 34 matching lines @@
     }
 }
 
 // This method is somewhat conservative in what it accepts.
 RuleFeatureSet::InvalidationSetMode RuleFeatureSet::supportsClassDescendantInvalidation(const CSSSelector& selector)
 {
     bool foundDescendantRelation = false;
     bool foundIdent = false;
     for (const CSSSelector* component = &selector; component; component = component->tagHistory()) {
 
         // FIXME: next up: Tag and Id.

[esprehn, 2014/04/01 08:23:29]

You should remove this comment, we support tags and ids now.

[rune, 2014/04/01 08:41:34]

No, we don't. We need to add them to the if-test below to set foundIdent, then
we need to introduce vectors for them in StyleInvalidator::RecursionData like we
have for classes and ids, and then use those vectors during invalidation.

-        if (component->m_match == CSSSelector::Class || component->isAttributeSelector()) {
+        if (component->m_match == CSSSelector::Class || component->isAttributeSelector() || component->isCustomPseudoElement()) {
             if (!foundDescendantRelation)
                 foundIdent = true;
         } else if (component->pseudoType() == CSSSelector::PseudoHost || component->pseudoType() == CSSSelector::PseudoAny) {
             if (const CSSSelectorList* selectorList = component->selectorList()) {
                 for (const CSSSelector* selector = selectorList->first(); selector; selector = CSSSelectorList::next(*selector)) {
                     InvalidationSetMode hostMode = supportsClassDescendantInvalidation(*selector);
                     if (hostMode == UseSubtreeStyleChange)
                         return foundDescendantRelation ? UseLocalStyleChange : UseSubtreeStyleChange;
                     if (hostMode == AddFeatures)
                         foundIdent = true;
@@ skipping 21 matching lines @@
 void RuleFeatureSet::extractInvalidationSetFeature(const CSSSelector& selector, InvalidationSetFeatures& features)
 {
     if (selector.m_match == CSSSelector::Tag)
         features.tagName = selector.tagQName().localName();
     else if (selector.m_match == CSSSelector::Id)
         features.id = selector.value();
     else if (selector.m_match == CSSSelector::Class)
         features.classes.append(selector.value());
     else if (selector.isAttributeSelector())
         features.attributes.append(selector.attribute().localName());
+    else if (selector.isCustomPseudoElement())
+        features.customPseudoElement = true;
 }
 
 RuleFeatureSet::RuleFeatureSet()
     : m_targetedStyleRecalcEnabled(RuntimeEnabledFeatures::targetedStyleRecalcEnabled())
 {
 }
 
 DescendantInvalidationSet* RuleFeatureSet::invalidationSetForSelector(const CSSSelector& selector)
 {
     if (selector.m_match == CSSSelector::Class)
@@ skipping 44 matching lines @@
     for (const CSSSelector* current = &selector; current; current = current->tagHistory()) {
         if (DescendantInvalidationSet* invalidationSet = invalidationSetForSelector(*current)) {
             if (!features.id.isEmpty())
                 invalidationSet->addId(features.id);
             if (!features.tagName.isEmpty())
                 invalidationSet->addTagName(features.tagName);
             for (Vector<AtomicString>::const_iterator it = features.classes.begin(); it != features.classes.end(); ++it)
                 invalidationSet->addClass(*it);
             for (Vector<AtomicString>::const_iterator it = features.attributes.begin(); it != features.attributes.end(); ++it)
                 invalidationSet->addAttribute(*it);
+            if (features.customPseudoElement)
+                invalidationSet->setCustomPseudoInvalid();
         } else if (current->pseudoType() == CSSSelector::PseudoHost || current->pseudoType() == CSSSelector::PseudoAny) {
             if (const CSSSelectorList* selectorList = current->selectorList()) {
                 for (const CSSSelector* selector = selectorList->first(); selector; selector = CSSSelectorList::next(*selector))
                     addFeaturesToInvalidationSets(*selector, features);
             }
         }
     }
 }
 
 void RuleFeatureSet::addContentAttr(const AtomicString& attributeName)
@@ skipping 194 matching lines @@
     if (node->isElementNode())
         m_pendingInvalidationMap.remove(toElement(node));
 }
 
 RuleFeatureSet::PendingInvalidationMap& RuleFeatureSet::pendingInvalidationMap()
 {
     return m_pendingInvalidationMap;
 }
 
 } // namespace WebCore