Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2191853004: [Android] Add step text for host_info when failures are detected. (Closed)

Created:
4 years, 4 months ago by rnephew (Reviews Here)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[Android] Add step text for host_info when failures are detected. BUG=592140 Committed: https://chromium.googlesource.com/chromium/tools/build/+/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7

Patch Set 1 #

Total comments: 3

Patch Set 2 : [Android] Add step text for host_info when failures are detected. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -63 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/host_info_failure.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/missing_device.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/src_side_script_fails.json View 1 1 chunk +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/test_failure.json View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
rnephew (Reviews Here)
4 years, 4 months ago (2016-07-28 22:24:42 UTC) #2
jbudorick
https://codereview.chromium.org/2191853004/diff/1/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (right): https://codereview.chromium.org/2191853004/diff/1/scripts/slave/recipe_modules/chromium_android/api.py#newcode422 scripts/slave/recipe_modules/chromium_android/api.py:422: results.presentation.step_text += ( We should look at doing this ...
4 years, 4 months ago (2016-07-28 22:43:42 UTC) #3
jbudorick
https://codereview.chromium.org/2191853004/diff/1/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (right): https://codereview.chromium.org/2191853004/diff/1/scripts/slave/recipe_modules/chromium_android/api.py#newcode422 scripts/slave/recipe_modules/chromium_android/api.py:422: results.presentation.step_text += ( On 2016/07/28 22:43:42, jbudorick wrote: > ...
4 years, 4 months ago (2016-07-28 22:46:22 UTC) #4
rnephew (Reviews Here)
https://codereview.chromium.org/2191853004/diff/1/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (right): https://codereview.chromium.org/2191853004/diff/1/scripts/slave/recipe_modules/chromium_android/api.py#newcode422 scripts/slave/recipe_modules/chromium_android/api.py:422: results.presentation.step_text += ( On 2016/07/28 22:46:22, jbudorick wrote: > ...
4 years, 4 months ago (2016-07-28 22:53:28 UTC) #5
jbudorick
lgtm
4 years, 4 months ago (2016-07-28 22:59:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191853004/20001
4 years, 4 months ago (2016-07-28 23:57:57 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/tools/build/+/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7
4 years, 4 months ago (2016-07-29 00:01:45 UTC) #10
ghost stip (do not use)
4 years, 4 months ago (2016-07-29 00:05:30 UTC) #11
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698