Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: third_party/WebKit/Source/web/WebAXObject.cpp

Issue 2191833003: Use text affinity to return correct accessible line boundaries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bug in browser_accessibility_win.cc Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/AssertMatchingEnums.cpp ('k') | third_party/WebKit/public/web/WebAXEnums.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebAXObject.cpp
diff --git a/third_party/WebKit/Source/web/WebAXObject.cpp b/third_party/WebKit/Source/web/WebAXObject.cpp
index 530489a30daea50b8430ee95cc101135c728dd00..05c7c8b40f5531099fe31a85354349d16bb46d8e 100644
--- a/third_party/WebKit/Source/web/WebAXObject.cpp
+++ b/third_party/WebKit/Source/web/WebAXObject.cpp
@@ -853,22 +853,26 @@ WebAXRole WebAXObject::role() const
return static_cast<WebAXRole>(m_private->roleValue());
}
-void WebAXObject::selection(WebAXObject& anchorObject, int& anchorOffset,
- WebAXObject& focusObject, int& focusOffset) const
+void WebAXObject::selection(WebAXObject& anchorObject, int& anchorOffset, WebAXTextAffinity& anchorAffinity,
+ WebAXObject& focusObject, int& focusOffset, WebAXTextAffinity& focusAffinity) const
{
if (isDetached()) {
anchorObject = WebAXObject();
anchorOffset = -1;
+ anchorAffinity = WebAXTextAffinityDownstream;
focusObject = WebAXObject();
focusOffset = -1;
+ focusAffinity = WebAXTextAffinityDownstream;
return;
}
AXObject::AXRange axSelection = m_private->selection();
anchorObject = WebAXObject(axSelection.anchorObject);
anchorOffset = axSelection.anchorOffset;
+ anchorAffinity = static_cast<WebAXTextAffinity>(axSelection.anchorAffinity);
focusObject = WebAXObject(axSelection.focusObject);
focusOffset = axSelection.focusOffset;
+ focusAffinity = static_cast<WebAXTextAffinity>(axSelection.focusAffinity);
return;
}
@@ -878,8 +882,8 @@ void WebAXObject::setSelection(const WebAXObject& anchorObject, int anchorOffset
if (isDetached())
return;
- AXObject::AXRange axSelection(anchorObject, anchorOffset,
- focusObject, focusOffset);
+ AXObject::AXRange axSelection(anchorObject, anchorOffset, TextAffinity::Upstream,
+ focusObject, focusOffset, TextAffinity::Downstream);
m_private->setSelection(axSelection);
return;
}
« no previous file with comments | « third_party/WebKit/Source/web/AssertMatchingEnums.cpp ('k') | third_party/WebKit/public/web/WebAXEnums.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698