Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: content/browser/accessibility/browser_accessibility_win.cc

Issue 2191833003: Use text affinity to return correct accessible line boundaries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bug in browser_accessibility_win.cc Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_win.cc
diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc
index cfae97a0f898750a173bca273c19e3d600d57cf1..85e100f01780c1b5744e4088ac8f7d454dc4b037 100644
--- a/content/browser/accessibility/browser_accessibility_win.cc
+++ b/content/browser/accessibility/browser_accessibility_win.cc
@@ -4373,17 +4373,26 @@ LONG BrowserAccessibilityWin::FindBoundary(
IA2TextBoundaryType ia2_boundary,
LONG start_offset,
ui::TextBoundaryDirection direction) {
+ // If the boundary is relative to the caret, use the selection
+ // affinity, otherwise default to downstream affinity.
+ ui::AXTextAffinity affinity =
+ start_offset == IA2_TEXT_OFFSET_CARET ?
+ manager()->GetTreeData().sel_focus_affinity :
+ ui::AX_TEXT_AFFINITY_DOWNSTREAM;
+
HandleSpecialTextOffset(text, &start_offset);
if (ia2_boundary == IA2_TEXT_BOUNDARY_WORD)
return GetWordStartBoundary(static_cast<int>(start_offset), direction);
- if (ia2_boundary == IA2_TEXT_BOUNDARY_LINE)
- return GetLineStartBoundary(static_cast<int>(start_offset), direction);
+ if (ia2_boundary == IA2_TEXT_BOUNDARY_LINE) {
+ return GetLineStartBoundary(
+ static_cast<int>(start_offset), direction, affinity);
+ }
ui::TextBoundaryType boundary = IA2TextBoundaryToTextBoundary(ia2_boundary);
const std::vector<int32_t>& line_breaks =
GetIntListAttribute(ui::AX_ATTR_LINE_BREAKS);
return ui::FindAccessibleTextBoundary(
- text, line_breaks, boundary, start_offset, direction);
+ text, line_breaks, boundary, start_offset, direction, affinity);
}
LONG BrowserAccessibilityWin::FindStartOfStyle(
« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_unittest.cc ('k') | content/common/accessibility_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698