Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 219183002: Disable the thread-safe MQ parser for main thread (Closed)

Created:
6 years, 8 months ago by Yoav Weiss
Modified:
6 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, kenneth.christiansen, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, rwlbuis, kareng
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Disable the thread-safe MQ parser for main thread This reverts commit d1eea2e66e64c3c019885ad7e94933aa0fc05576. On top of that, this CL makes sure that only the preloader uses the thread safe MQ parser. That's in order to reduce the risk of breaking content when introducing the new MQ parser. BUG=358078 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170494

Patch Set 1 #

Patch Set 2 : Testing BisonCSSParser #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M Source/core/css/MediaList.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/MediaList.cpp View 1 chunk +9 lines, -1 line 0 comments Download
M Source/core/css/MediaQuerySetTest.cpp View 1 2 chunks +7 lines, -1 line 0 comments Download
M Source/core/css/parser/BisonCSSParser.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Yoav Weiss
Since we've discovered some potential compatibility issues with the thread safe MQ parser, we may ...
6 years, 8 months ago (2014-03-31 11:06:52 UTC) #1
eseidel
lgtm, but you'll need a Merge-Approved from the M35 release manager (who I think is ...
6 years, 8 months ago (2014-03-31 15:45:13 UTC) #2
Yoav Weiss
On 2014/03/31 15:45:13, eseidel wrote: > lgtm, but you'll need a Merge-Approved from the M35 ...
6 years, 8 months ago (2014-03-31 16:43:46 UTC) #3
eseidel
I see. I'm OK with us understanding that BisonCSSParser is broken (fails some tests) as ...
6 years, 8 months ago (2014-03-31 17:13:24 UTC) #4
eseidel
I've confirmed that kareng is the release owner for M35, so it's her Merge-Approved which ...
6 years, 8 months ago (2014-03-31 17:14:17 UTC) #5
Yoav Weiss
On 2014/03/31 17:13:24, eseidel wrote: > I see. I'm OK with us understanding that BisonCSSParser ...
6 years, 8 months ago (2014-03-31 17:30:01 UTC) #6
eseidel
lgtm to land on trunk. We'll land on trunk first, let it bake in canary ...
6 years, 8 months ago (2014-03-31 21:50:24 UTC) #7
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 8 months ago (2014-03-31 21:53:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/219183002/20001
6 years, 8 months ago (2014-03-31 21:53:39 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 00:08:46 UTC) #10
Message was sent while issue was closed.
Change committed as 170494

Powered by Google App Engine
This is Rietveld 408576698