Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2191823002: [turbofan] Refactor the lowering of element/property accesses. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Refactor the lowering of element/property accesses. Split the monster methods in JSNativeContextSpecialization into smaller ones, adding appropriate helpers. Improve the condition checking for strings and numbers using CheckString/CheckNumber when applicable. Also try to merge compatible PropertyAccessInfos, to avoid running into the polymorphic case whenever possible. Drive-by-fix: Don't try to resurrect dead nodes during LoadElimination. With the improve code generation for monomorphic loads, we seem to trigger the dead node resurrection. R=epertoso@chromium.org BUG=v8:4930, v8:5141 Committed: https://crrev.com/1bce27906d5933ad05310987e3dd91782324e712 Cr-Commit-Position: refs/heads/master@{#38127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+602 lines, -470 lines) Patch
M src/compiler/access-info.h View 3 chunks +15 lines, -14 lines 0 comments Download
M src/compiler/access-info.cc View 10 chunks +80 lines, -42 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 2 chunks +35 lines, -1 line 0 comments Download
M src/compiler/js-native-context-specialization.cc View 7 chunks +459 lines, -409 lines 0 comments Download
M src/compiler/load-elimination.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/field-index.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/handles.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 4 months ago (2016-07-28 09:08:41 UTC) #1
Benedikt Meurer
Hey Enrico, Here's some refactoring in preparation for proper map check elimination. Please take a ...
4 years, 4 months ago (2016-07-28 09:09:58 UTC) #4
epertoso
lgtm
4 years, 4 months ago (2016-07-28 09:51:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191823002/1
4 years, 4 months ago (2016-07-28 09:52:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 09:54:15 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 09:57:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bce27906d5933ad05310987e3dd91782324e712
Cr-Commit-Position: refs/heads/master@{#38127}

Powered by Google App Engine
This is Rietveld 408576698