Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2191803002: Remove hasGrammarMarker from internals (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove hasGrammarMarker from internals BUG=619452 TEST=n/a; no behavior change Committed: https://crrev.com/bce93917093ec0d1acd2de4c769ffd18c7e3c075 Cr-Commit-Position: refs/heads/master@{#408541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Xiaocheng
PTAL.
4 years, 4 months ago (2016-07-28 09:37:02 UTC) #6
tkent
lgtm
4 years, 4 months ago (2016-07-28 23:27:56 UTC) #7
yosin_UTC9
lgtm
4 years, 4 months ago (2016-07-29 01:04:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191803002/1
4 years, 4 months ago (2016-07-29 01:04:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 01:09:47 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bce93917093ec0d1acd2de4c769ffd18c7e3c075 Cr-Commit-Position: refs/heads/master@{#408541}
4 years, 4 months ago (2016-07-29 01:11:53 UTC) #13
Xiaocheng
4 years, 4 months ago (2016-08-04 07:11:54 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2210863002/ by xiaochengh@chromium.org.

The reason for reverting is: Blink may still draw grammar markers when "Ask
Google for suggestion" is checked, so testing of grammar markers should not be
removed.

BUG=633641
TBR=yosin@chromium.org, tkent@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698