Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 21918002: Add start and end profiling time to v8::CpuProfile (Closed)

Created:
7 years, 4 months ago by yurys
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add start and end profiling time to v8::CpuProfile I'm going to change CPU profiler API and deprecate GetSelfTime, GetTotalTime and GetTotalSamplesCount on CpuProfileNode as all of those values are derived from self samples count and sampling rate. The sampling rate in turn is calculate based on the profiling duration so having start/end time and total sample count is enough for calculating smpling rate. BUG=267595 R=alph@chromium.org, bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16039

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -5 lines) Patch
M include/v8-profiler.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/profile-generator.h View 1 chunk +8 lines, -5 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yurys
7 years, 4 months ago (2013-08-02 16:32:23 UTC) #1
alph
lgtm https://codereview.chromium.org/21918002/diff/1/include/v8-profiler.h File include/v8-profiler.h (right): https://codereview.chromium.org/21918002/diff/1/include/v8-profiler.h#newcode153 include/v8-profiler.h:153: * since the Epoch ). nit: space after ...
7 years, 4 months ago (2013-08-02 16:43:49 UTC) #2
yurys
https://codereview.chromium.org/21918002/diff/1/include/v8-profiler.h File include/v8-profiler.h (right): https://codereview.chromium.org/21918002/diff/1/include/v8-profiler.h#newcode153 include/v8-profiler.h:153: * since the Epoch ). On 2013/08/02 16:43:49, alph ...
7 years, 4 months ago (2013-08-02 16:46:02 UTC) #3
yurys
Benedikt: can you do OWNER review please?
7 years, 4 months ago (2013-08-02 16:46:23 UTC) #4
Benedikt Meurer
LGTM
7 years, 4 months ago (2013-08-03 05:15:02 UTC) #5
yurys
7 years, 4 months ago (2013-08-05 07:17:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r16039 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698