Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2191793002: Revert of Fix extension bindings injection for iframes (Closed)

Created:
4 years, 4 months ago by benwells
Modified:
4 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix extension bindings injection for iframes (patchset #5 id:120001 of https://codereview.chromium.org/2151693002/ ) Reason for revert: This Cl caused a test failure under DrMemory. First build with failing test: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Browser%20%28DrMemory%20full%29%20%282%29/builds/3969 Sample failure output: FramesExtensionBindingsApiTest.FramesBeforeNavigation: [1420:4432:0722/173632:WARNING:chrome_browser_main_win.cc(419)] Command line too long for RegisterApplicationRestart [1420:4432:0722/174006:INFO:CONSOLE(0)] "Denying load of chrome-extension://ficgdghpakbhhkmdjamiedmcoobamkoo/nonexistent.html. Resources must be listed in the web_accessible_resources manifest key in order to be loaded by pages outside the extension.", source: about:blank (0) [1420:4432:0722/174015:INFO:CONSOLE(24)] "caught exception: SecurityError: Blocked a frame with origin "http://127.0.0.1:50285" from accessing a cross-origin frame.", source: http://127.0.0.1:50285/extensions/api_test/bindings/frames_before_navigation.html (24) [1420:4432:0722/174018:INFO:CONSOLE(0)] "Denying load of chrome-extension://ficgdghpakbhhkmdjamiedmcoobamkoo/nonexistent.html. Resources must be listed in the web_accessible_resources manifest key in order to be loaded by pages outside the extension.", source: about:blank (0) [1420:4988:0722/174053:WARNING:embedded_test_server.cc(193)] Request not handled. Returning 404: /favicon.ico c:\b\build\slave\drm-cr\build\src\chrome\browser\extensions\extension_bindings_apitest.cc(257): error: Value of: page_success Actual: false Expected: true Original issue's description: > Fix extension bindings injection for iframes > > For iframes, we don't want to use the source url for determining the > associated extension because it starts out with an about:blank context > that is scriptable by its parent. > > BUG=573131 > > Committed: https://crrev.com/91f655b19888da3f86b57ad8c548da93e7b9aba4 > Cr-Commit-Position: refs/heads/master@{#407214} TBR=rdevlin.cronin@chromium.org,asargent@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=573131 Committed: https://crrev.com/4b8ca0a9fbbe79fa5a7819917e5a31d237f0f499 Cr-Commit-Position: refs/heads/master@{#408355}

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
benwells
Created Revert of Fix extension bindings injection for iframes
4 years, 4 months ago (2016-07-28 06:49:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191793002/1
4 years, 4 months ago (2016-07-28 06:49:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 07:38:50 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 07:40:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b8ca0a9fbbe79fa5a7819917e5a31d237f0f499
Cr-Commit-Position: refs/heads/master@{#408355}

Powered by Google App Engine
This is Rietveld 408576698