Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Unified Diff: blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContextDelegate.java

Issue 2191743002: Setup the delegate in Chrome, so we may put chrome java functions we need in blimp to the delegate … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resovle merge conflicts. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContextDelegate.java
diff --git a/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpSettingsCallbacks.java b/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContextDelegate.java
similarity index 51%
copy from blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpSettingsCallbacks.java
copy to blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContextDelegate.java
index b79223c9a1e9d3fd4c3f11ad473feaebdde06b20..e5ba36bda678a409a490a1270d2b1d2f8467a8e6 100644
--- a/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpSettingsCallbacks.java
+++ b/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContextDelegate.java
@@ -5,13 +5,13 @@
package org.chromium.blimp_public;
/**
- * Callback interface for Blimp to call functions in Chrome from Blimp settings.
- * Chrome should implements this interface and pass it to Blimp via BlimpClientContext.
+ * Interface for java functionalities in chrome that are called from Blimp.
nyquist 2016/07/28 19:15:34 I think we can just use 'embedder' instead of Chro
xingliu 2016/07/28 22:43:09 Done.
+ *
+ * Blimp can call embedder functions via this interface.
*/
-public interface BlimpSettingsCallbacks {
-
+public interface BlimpClientContextDelegate {
/**
* Request Chrome to restart browser.
*/
- public void onRestartBrowserRequested();
+ public void restartBrowser();
nyquist 2016/07/28 19:15:34 I think this can be removed for now.
xingliu 2016/07/28 22:43:09 Done.
}

Powered by Google App Engine
This is Rietveld 408576698