Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2191733002: make use of use_gconf & use_glib gn args in content/browser/ (Closed)

Created:
4 years, 4 months ago by Mostyn Bramley-Moore
Modified:
4 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

make use of use_gconf & use_glib gn args in content/browser/ Committed: https://crrev.com/ebc6e12c115205ceb95330395da611991d874e11 Cr-Commit-Position: refs/heads/master@{#408362}

Patch Set 1 #

Patch Set 2 : typo fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M content/browser/BUILD.gn View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Mostyn Bramley-Moore
@Avi: please take a look at this small GN cleanup.
4 years, 4 months ago (2016-07-27 23:20:06 UTC) #3
Avi (use Gerrit)
lgtm
4 years, 4 months ago (2016-07-28 02:24:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191733002/20001
4 years, 4 months ago (2016-07-28 08:50:39 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 08:53:58 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 08:55:32 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ebc6e12c115205ceb95330395da611991d874e11
Cr-Commit-Position: refs/heads/master@{#408362}

Powered by Google App Engine
This is Rietveld 408576698