Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 219173003: Initialize elements pointer in BuildCloneShallowArray when allocation folding is turned off. (Closed)

Created:
6 years, 8 months ago by Hannes Payer (out of office)
Modified:
6 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Initialize elements pointer in BuildCloneShallowArray when allocation folding is turned off. BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/hydrogen.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
6 years, 8 months ago (2014-03-31 12:08:49 UTC) #1
Hannes Payer (out of office)
6 years, 8 months ago (2014-03-31 12:08:49 UTC) #2
mvstanton
Good catch. LGTM, but protect with a cc-test to trigger this case. --Michael
6 years, 8 months ago (2014-03-31 12:34:05 UTC) #3
Hannes Payer (out of office)
6 years, 8 months ago (2014-04-17 11:58:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r20843 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698