Issue 219173002: Cleanup string-stream module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 219173002: Cleanup string-stream module. (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer

Modified:
6 years, 8 months ago

Reviewers:
Sven Panne

CC:
v8-dev, tfarina

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Cleanup string-stream module. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20344

Patch Set 1 #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -72 lines)			Patch
	M	src/string-stream.h	View		8 chunks	+17 lines, -42 lines	2 comments	Download
	M	src/string-stream.cc	View		1 chunk	+6 lines, -30 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

Committed patchset #1 manually as r20344 (tree was closed).

6 years, 8 months ago (2014-03-31 11:13:45 UTC) #3

tfarina

6 years, 8 months ago (2014-03-31 15:51:18 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/219173002/diff/1/src/string-stream.h
File src/string-stream.h (left):

https://codereview.chromium.org/219173002/diff/1/src/string-stream.h#oldcode1
src/string-stream.h:1: // Copyright 2006-2008 the V8 project authors. All rights
reserved.
Are you sure it is OK to change copyright? I doubt it is. Did you ask any
lawyer?

https://codereview.chromium.org/219173002/diff/1/src/string-stream.h#oldcode34
src/string-stream.h:34: 
why? don't we always leave two spaces between classes, functions, namespaces
etc?

Expand Messages | Collapse Messages