Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2191713003: [Extensions UI] Check for a browser not being found (Closed)

Created:
4 years, 4 months ago by Devlin
Modified:
4 years, 4 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions UI] Check for a browser not being found chrome::FindBrowserWithWebContents() can return null in some cases. Guard against it in showing the warning bubble. BUG=631362 Committed: https://crrev.com/8996565733bc75e7a029e8b8d4612e2b013e63d2 Cr-Commit-Position: refs/heads/master@{#408403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/extensions/settings_api_bubble_helpers.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Devlin
Hey Ben, Finnur's out for the summer; mind taking a quick look?
4 years, 4 months ago (2016-07-28 00:15:54 UTC) #6
benwells
lgtm
4 years, 4 months ago (2016-07-28 07:52:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191713003/1
4 years, 4 months ago (2016-07-28 15:01:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 15:44:52 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 15:46:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8996565733bc75e7a029e8b8d4612e2b013e63d2
Cr-Commit-Position: refs/heads/master@{#408403}

Powered by Google App Engine
This is Rietveld 408576698