appengine/cmd/milo/logdog/stream.proto - Issue 2191693003: Milo: Add LogDog annotation stream support.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/cmd/milo/logdog/stream.proto

Issue 2191693003: Milo: Add LogDog annotation stream support. (Closed) Base URL: https://github.com/luci/luci-go@master

Patch Set: Fix successful build state, derive more Swarming parameters from milo proto common code. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The LUCI Authors. All rights reserved.

	2 // Use of this source code is governed under the Apache License, Version 2.0

	3 // that can be found in the LICENSE file.

	4

	5 syntax = "proto3";

	6

	7 package logdog;

	8

	9 import "github.com/luci/luci-go/common/proto/milo/annotations.proto";

	10

	11 /**
	nodir 2016/07/29 18:42:06 nit: I think we use // everywhere, in particular i nit: I think we use // everywhere, in particular in milo dnj 2016/07/29 19:57:35 Done. Show quoted text On 2016/07/29 18:42:06, nodir wrote: > nit: I think we use // everywhere, in particular in milo Done.
	12 * Item is a full annotation protobuf state item.
	nodir 2016/07/29 18:42:06 please add a comment that this message is not inte please add a comment that this message is not intended to be used outside of this package, and actually an implementation detail dnj 2016/07/29 19:57:35 Done. Show quoted text On 2016/07/29 18:42:06, nodir wrote: > please add a comment that this message is not intended to be used outside of > this package, and actually an implementation detail Done.
	13 */

	14 message Item {

	15 /** Step is the root annotation step. */

	16 milo.Step step = 1;

	17

	18 /** Finished is true if this is the last annotation protobuf in the stream. */

	19 bool finished = 2;

	20 }

OLD	NEW