Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2191673004: Revert of [Android] Sanitize APK signing file timestamps. (Closed)

Created:
4 years, 4 months ago by agrieve
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Sanitize APK signing file timestamps. (patchset #3 id:40001 of https://codereview.chromium.org/2176023002/ ) Reason for revert: Breaking builds: https://bugs.chromium.org/p/chromium/issues/detail?id=632400 Original issue's description: > [Android] Sanitize APK signing file timestamps. > > BUG=630931 > > Committed: https://crrev.com/61e1a7ac087039d43e694c08584724252f9785ce > Cr-Commit-Position: refs/heads/master@{#408389} TBR=stip@chromium.org,jbudorick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630931 Committed: https://crrev.com/c7b32ac6019e85f6485d46860eb43bdbaf72a76f Cr-Commit-Position: refs/heads/master@{#408425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M build/android/gyp/finalize_apk.py View 2 chunks +0 lines, -10 lines 0 comments Download
M build/android/gyp/util/build_utils.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
agrieve
Created Revert of [Android] Sanitize APK signing file timestamps.
4 years, 4 months ago (2016-07-28 17:33:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191673004/1
4 years, 4 months ago (2016-07-28 17:33:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 17:35:54 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 17:37:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7b32ac6019e85f6485d46860eb43bdbaf72a76f
Cr-Commit-Position: refs/heads/master@{#408425}

Powered by Google App Engine
This is Rietveld 408576698