Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 2191663004: [fullcode][mips][mips64][ppc][s390] Avoid trashing of a home object when doing a count operation wi… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 3185 matching lines...) Expand 10 before | Expand all | Expand 10 after
3196 VisitForStackValue(prop->obj()); 3196 VisitForStackValue(prop->obj());
3197 __ lw(LoadDescriptor::ReceiverRegister(), MemOperand(sp, 0)); 3197 __ lw(LoadDescriptor::ReceiverRegister(), MemOperand(sp, 0));
3198 EmitNamedPropertyLoad(prop); 3198 EmitNamedPropertyLoad(prop);
3199 break; 3199 break;
3200 } 3200 }
3201 3201
3202 case NAMED_SUPER_PROPERTY: { 3202 case NAMED_SUPER_PROPERTY: {
3203 VisitForStackValue(prop->obj()->AsSuperPropertyReference()->this_var()); 3203 VisitForStackValue(prop->obj()->AsSuperPropertyReference()->this_var());
3204 VisitForAccumulatorValue( 3204 VisitForAccumulatorValue(
3205 prop->obj()->AsSuperPropertyReference()->home_object()); 3205 prop->obj()->AsSuperPropertyReference()->home_object());
3206 PushOperand(result_register());
3207 const Register scratch = a1; 3206 const Register scratch = a1;
3208 __ lw(scratch, MemOperand(sp, kPointerSize)); 3207 __ lw(scratch, MemOperand(sp, 0)); // this
3209 PushOperands(scratch, result_register()); 3208 PushOperands(result_register(), scratch, result_register());
3210 EmitNamedSuperPropertyLoad(prop); 3209 EmitNamedSuperPropertyLoad(prop);
3211 break; 3210 break;
3212 } 3211 }
3213 3212
3214 case KEYED_SUPER_PROPERTY: { 3213 case KEYED_SUPER_PROPERTY: {
3215 VisitForStackValue(prop->obj()->AsSuperPropertyReference()->this_var()); 3214 VisitForStackValue(prop->obj()->AsSuperPropertyReference()->this_var());
3216 VisitForAccumulatorValue( 3215 VisitForStackValue(
3217 prop->obj()->AsSuperPropertyReference()->home_object()); 3216 prop->obj()->AsSuperPropertyReference()->home_object());
3218 const Register scratch = a1;
3219 const Register scratch1 = t0;
3220 __ Move(scratch, result_register());
3221 VisitForAccumulatorValue(prop->key()); 3217 VisitForAccumulatorValue(prop->key());
3222 PushOperands(scratch, result_register()); 3218 const Register scratch1 = a1;
3223 __ lw(scratch1, MemOperand(sp, 2 * kPointerSize)); 3219 const Register scratch2 = t0;
3224 PushOperands(scratch1, scratch, result_register()); 3220 __ lw(scratch1, MemOperand(sp, 1 * kPointerSize)); // this
3221 __ lw(scratch2, MemOperand(sp, 0 * kPointerSize)); // home object
3222 PushOperands(result_register(), scratch1, scratch2, result_register());
3225 EmitKeyedSuperPropertyLoad(prop); 3223 EmitKeyedSuperPropertyLoad(prop);
3226 break; 3224 break;
3227 } 3225 }
3228 3226
3229 case KEYED_PROPERTY: { 3227 case KEYED_PROPERTY: {
3230 VisitForStackValue(prop->obj()); 3228 VisitForStackValue(prop->obj());
3231 VisitForStackValue(prop->key()); 3229 VisitForStackValue(prop->key());
3232 __ lw(LoadDescriptor::ReceiverRegister(), 3230 __ lw(LoadDescriptor::ReceiverRegister(),
3233 MemOperand(sp, 1 * kPointerSize)); 3231 MemOperand(sp, 1 * kPointerSize));
3234 __ lw(LoadDescriptor::NameRegister(), MemOperand(sp, 0)); 3232 __ lw(LoadDescriptor::NameRegister(), MemOperand(sp, 0));
(...skipping 551 matching lines...) Expand 10 before | Expand all | Expand 10 after
3786 reinterpret_cast<uint32_t>( 3784 reinterpret_cast<uint32_t>(
3787 isolate->builtins()->OnStackReplacement()->entry())); 3785 isolate->builtins()->OnStackReplacement()->entry()));
3788 return ON_STACK_REPLACEMENT; 3786 return ON_STACK_REPLACEMENT;
3789 } 3787 }
3790 3788
3791 3789
3792 } // namespace internal 3790 } // namespace internal
3793 } // namespace v8 3791 } // namespace v8
3794 3792
3795 #endif // V8_TARGET_ARCH_MIPS 3793 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698