[fullcode][mips][mips64][ppc][s390] Avoid trashing of a home object when doing a count operation wi…

[fullcode][mips][mips64][ppc][s390] Avoid trashing of a home object when doing a count operation with keyed load/store to a super.

BUG=chromium:631917
Committed: https://crrev.com/fc66694de85bf26bb00a51cc21ab4c32770c1f56
Cr-Commit-Position: refs/heads/master@{#38139}

[Igor Sheludko, 2016-07-28 12:18:31]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 12:18:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-07-28 12:18:41]

ishell@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Igor Sheludko, 2016-07-28 12:18:41]

PTAL

[Jakob Kummerow, 2016-07-28 12:36:02]

https://codereview.chromium.org/2191663004/diff/1/src/full-codegen/mips/full-...
File src/full-codegen/mips/full-codegen-mips.cc (right):

https://codereview.chromium.org/2191663004/diff/1/src/full-codegen/mips/full-...
src/full-codegen/mips/full-codegen-mips.cc:3207: __ lw(scratch, MemOperand(sp,
kPointerSize));
This loads a different value now, that doesn't seem intentional.
s/kPointerSize/0/?

https://codereview.chromium.org/2191663004/diff/1/src/full-codegen/mips/full-...
src/full-codegen/mips/full-codegen-mips.cc:3220: __ lw(scratch1, MemOperand(sp,
2 * kPointerSize));
I think this should be s/2 * kPointerSize/kPointerSize/, because now there's one
less push happening before we get here.

https://codereview.chromium.org/2191663004/diff/1/src/full-codegen/mips/full-...
src/full-codegen/mips/full-codegen-mips.cc:3221: __ lw(scratch2, MemOperand(sp,
1 * kPointerSize));
...and this should be s/1 * kPointerSize/0/ by the same reasoning.

[commit-bot: I haz the power, 2016-07-28 12:38:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 12:38:32]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-07-28 14:02:05]

Thanks! I fixed the issue (now for real :)

[Igor Sheludko, 2016-07-28 14:02:22]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 14:02:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 14:23:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 14:23:44]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2016-07-28 14:24:58]

lgtm

[Igor Sheludko, 2016-07-28 14:26:25]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-07-28 14:26:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 14:28:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-28 14:31:17]

Description was changed from

==========
[fullcode][mips][mips64][ppc][s390] Avoid trashing of a home object when doing a
count operation with keyed load/store to a super.

BUG=chromium:631917
==========

to

==========
[fullcode][mips][mips64][ppc][s390] Avoid trashing of a home object when doing a
count operation with keyed load/store to a super.

BUG=chromium:631917

Committed: https://crrev.com/fc66694de85bf26bb00a51cc21ab4c32770c1f56
Cr-Commit-Position: refs/heads/master@{#38139}
==========

[commit-bot: I haz the power, 2016-07-28 14:31:18]

Patchset 2 (id:??) landed as
https://crrev.com/fc66694de85bf26bb00a51cc21ab4c32770c1f56
Cr-Commit-Position: refs/heads/master@{#38139}