Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2191643002: Label sandbox job object OOM as OOM in process termination. (Closed)

Created:
4 years, 4 months ago by Will Harris
Modified:
4 years, 4 months ago
Reviewers:
Mark Mentovai, nasko
CC:
chromium-reviews, wfh+watch_chromium.org, pennymac+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Label sandbox job object OOM as OOM in process termination. BUG=614440, 630472 TEST=go to chrome://memory-exhaust on 64-bit Chrome and verify it gives the OOM sad tab. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/48c487e61345a4b96040d04e7cdc59b38c49c891 Cr-Commit-Position: refs/heads/master@{#408259}

Patch Set 1 #

Patch Set 2 : should not include windows code in platform independent parts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M base/process/kill.h View 1 chunk +10 lines, -0 lines 0 comments Download
M base/process/kill_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/app/content_main_runner.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M sandbox/win/src/sandbox_types.h View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
Will Harris
I forgot this exit code also means OOM.
4 years, 4 months ago (2016-07-27 19:37:38 UTC) #4
Mark Mentovai
LGTM
4 years, 4 months ago (2016-07-27 19:43:08 UTC) #5
Mark Mentovai
P.S. Thanks for the static_assert!
4 years, 4 months ago (2016-07-27 19:43:16 UTC) #6
Will Harris
On 2016/07/27 19:43:16, Mark Mentovai wrote: > P.S. Thanks for the static_assert! yup dependencies are ...
4 years, 4 months ago (2016-07-27 19:44:35 UTC) #7
Will Harris
nasko - had to correct a header location in content_main_runner.cc in ps2 - PTAL.
4 years, 4 months ago (2016-07-27 21:05:24 UTC) #9
nasko
LGTM
4 years, 4 months ago (2016-07-27 21:44:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191643002/20001
4 years, 4 months ago (2016-07-27 21:51:23 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/226475)
4 years, 4 months ago (2016-07-27 22:02:03 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191643002/20001
4 years, 4 months ago (2016-07-27 22:25:21 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-27 22:49:03 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 22:50:45 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/48c487e61345a4b96040d04e7cdc59b38c49c891
Cr-Commit-Position: refs/heads/master@{#408259}

Powered by Google App Engine
This is Rietveld 408576698