third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp - Issue 2191633003: Move ResourceClient to Oilpan heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

Issue 2191633003: Move ResourceClient to Oilpan heap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-raw-resource-client

Patch Set: fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/Resource.cpp ('K') | « third_party/WebKit/Source/core/fetch/ResourceClientWalker.h ('k') | third_party/WebKit/Source/core/fetch/ScriptResource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

index c4ab711b0903d38ea0d8121df4aa7cffac881516..ef7fba83023885ab6c4b059a4259b69770910454 100644

--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

@@ -403,7 +403,7 @@ void ResourceFetcher::updateMemoryCacheStats(Resource* resource, RevalidationPol

// would be dead if MemoryCache holds weak references to Resource).

// Currently we check references to Resource from ResourceClient and

// |m_preloads| only, because they are major sources of references.

- if (resource && !resource->hasClientsOrObservers() && (!m_preloads || !m_preloads->contains(resource))) {

+ if (resource && !resource->isAlive() && (!m_preloads || !m_preloads->contains(resource))) {

DEFINE_RESOURCE_HISTOGRAM("Dead.");

}

@@ -491,7 +491,7 @@ Resource* ResourceFetcher::requestResource(FetchRequest& request, const Resource

return nullptr;

}

- if (!resource->hasClientsOrObservers())

+ if (!resource->isAlive())

m_deadStatsRecorder.update(policy);

if (policy != Use)