third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp - Issue 2191633003: Move ResourceClient to Oilpan heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

Issue 2191633003: Move ResourceClient to Oilpan heap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-raw-resource-client

Patch Set: fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/ImageResource.cpp ('k') | third_party/WebKit/Source/core/fetch/MemoryCache.cpp » ('j') | third_party/WebKit/Source/core/fetch/Resource.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

diff --git a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

index ea1834346dac8c0a50ca07cb69ee3934aaee2c1a..27aeb3213ec9235bdd720ac6163f3e61f714882c 100644

--- a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

+++ b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

@@ -308,7 +308,7 @@ TEST(ImageResourceTest, DecodedDataRemainsWhileHasClients)

// The prune comes when the ImageResource still has clients. The image should not be deleted.

cachedImage->prune();

- ASSERT_TRUE(cachedImage->hasClientsOrObservers());

+ ASSERT_TRUE(cachedImage->isAlive());

ASSERT_TRUE(cachedImage->hasImage());

ASSERT_FALSE(cachedImage->getImage()->isNull());

@@ -316,7 +316,7 @@ TEST(ImageResourceTest, DecodedDataRemainsWhileHasClients)

// deleted by prune.

client->removeAsClient();

cachedImage->prune();

- ASSERT_FALSE(cachedImage->hasClientsOrObservers());

+ ASSERT_FALSE(cachedImage->isAlive());

ASSERT_TRUE(cachedImage->hasImage());

// TODO(hajimehoshi): Should check cachedImage doesn't have decoded image

// data.

@@ -614,7 +614,7 @@ TEST(ImageResourceTest, AddClientAfterPrune)

client1->removeAsClient();

- EXPECT_FALSE(imageResource->hasClientsOrObservers());

+ EXPECT_FALSE(imageResource->isAlive());

imageResource->prune();