third_party/WebKit/Source/core/fetch/ResourceClient.h - Issue 2191633003: Move ResourceClient to Oilpan heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceClient.h

Issue 2191633003: Move ResourceClient to Oilpan heap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-raw-resource-client

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/Resource.cpp ('K') | « third_party/WebKit/Source/core/fetch/Resource.cpp ('k') | third_party/WebKit/Source/core/fetch/ResourceClientOrObserverWalker.h » ('j') | third_party/WebKit/Source/core/fetch/ResourceClientWalker.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ResourceClient.h

diff --git a/third_party/WebKit/Source/core/fetch/ResourceClient.h b/third_party/WebKit/Source/core/fetch/ResourceClient.h

index bdd9587a1b87ce94a5aef7933c619b99e91c6cdc..c33a0d07b1c5d43b6d428aff802653bae45360f7 100644

--- a/third_party/WebKit/Source/core/fetch/ResourceClient.h

+++ b/third_party/WebKit/Source/core/fetch/ResourceClient.h

@@ -26,14 +26,14 @@

#define ResourceClient_h

#include "core/CoreExport.h"

+#include "platform/heap/Handle.h"

#include "wtf/Forward.h"

#include "wtf/text/WTFString.h"

namespace blink {

class Resource;

-// TODO(Oilpan): Move ResourceClient to Oilpan's heap.

-class CORE_EXPORT ResourceClient {

+class CORE_EXPORT ResourceClient : public GarbageCollectedMixin {

public:

enum ResourceClientType {

BaseResourceType,

@@ -53,6 +53,8 @@ public:

// Name for debugging, e.g. shown in memory-infra.

virtual String debugName() const = 0;

+ DEFINE_INLINE_VIRTUAL_TRACE() {}

protected:

ResourceClient() { }

};