Issue 219163010: MIPS: Reland and fix "Fix LoadFieldByIndex to take mutable heap-numbers into account."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 219163010: MIPS: Reland and fix "Fix LoadFieldByIndex to take mutable heap-numbers into account." (Closed)

Created:
6 years, 8 months ago by palfia

Modified:
6 years, 8 months ago

Reviewers:
Paul Lind, Toon Verwaest, kisg, kilvadyb, danno, dusmil

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Reland and fix "Fix LoadFieldByIndex to take mutable heap-numbers into account." Port r20358 (5e9b653d) BUG= R=plind44@gmail.com Committed: https://code.google.com/p/v8/source/detail?r=20369

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -1 line)			Patch
M	src/mips/lithium-codegen-mips.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	2 chunks	+49 lines, -0 lines	1 comment	Download
M	src/mips/lithium-mips.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

LGTM, just fix the nit when you land it. https://codereview.chromium.org/219163010/diff/1/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right): https://codereview.chromium.org/219163010/diff/1/src/mips/lithium-codegen-mips.cc#newcode5801 src/mips/lithium-codegen-mips.cc:5801: ...

6 years, 8 months ago (2014-03-31 22:39:59 UTC) #2

palfia

On 2014/03/31 22:39:59, Paul Lind wrote: > LGTM, just fix the nit when you land ...

6 years, 8 months ago (2014-03-31 22:48:29 UTC) #3

palfia

6 years, 8 months ago (2014-03-31 22:49:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r20369 (presubmit successful).

Expand Messages | Collapse Messages