chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java - Issue 2191593002: 📰 Add a spinner to indicate content is loading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 2191593002: 📰 Add a spinner to indicate content is loading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unit tests, add an extra one Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressViewHolder.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

index e47f75262de354b61ea90f2da35d3320e077ff9c..8e79401fd4cb66837a3bb4cf0adbbcb6643c92f3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

@@ -32,6 +32,10 @@ public static boolean isCategoryStatusInitOrAvailable(int status) {

return status == CategoryStatus.INITIALIZING || isCategoryStatusAvailable(status);

}

+ public static boolean isCategoryLoading(int status) {

+ return status == CategoryStatus.AVAILABLE_LOADING || status == CategoryStatus.INITIALIZING;

+ }

/**

* Creates a SnippetsBridge for getting snippet data for the current user.