chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageListItem.java - Issue 2191593002: 📰 Add a spinner to indicate content is loading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageListItem.java

Issue 2191593002: 📰 Add a spinner to indicate content is loading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unit tests, add an extra one Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageListItem.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageListItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageListItem.java

index b3aec14836e2f54e128d6952b67ed92264d953bf..9a73f1377c98dd71970f3b0b8e0b930ff0331754 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageListItem.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageListItem.java

@@ -18,7 +18,7 @@

* @see NewTabPageListItem#getType()

@IntDef({VIEW_TYPE_ABOVE_THE_FOLD, VIEW_TYPE_HEADER, VIEW_TYPE_SNIPPET, VIEW_TYPE_SPACING,

- VIEW_TYPE_STATUS})

+ VIEW_TYPE_STATUS, VIEW_TYPE_PROGRESS})

@Retention(RetentionPolicy.SOURCE)

public @interface ViewType {}

@@ -53,6 +53,12 @@

public static final int VIEW_TYPE_STATUS = 5;

/**

+ * View type for a {@link ProgressListItem}, the progress indicator.

+ * @see Adapter#getItemViewType(int)

+ */

+ public static final int VIEW_TYPE_PROGRESS = 6;

+ /**

* Returns the type ({@link ViewType}) of this list item. This is so we can

* distinguish between different elements that are held in a single RecyclerView holder.